Differential D51229

kyua: Try harder to delete directories.
ClosedPublic
Actions

Authored by des on Wed, Jul 9, 7:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 26, 12:58 AM

	Unknown Object (File)
	Fri, Jul 25, 7:02 PM

	Unknown Object (File)
	Fri, Jul 25, 1:12 PM

	Unknown Object (File)
	Fri, Jul 25, 8:52 AM

	Unknown Object (File)
	Thu, Jul 24, 5:53 PM

	Unknown Object (File)
	Wed, Jul 23, 4:11 PM

	Unknown Object (File)
	Sun, Jul 20, 3:24 PM

	Unknown Object (File)
	Sun, Jul 20, 3:12 PM

View All 16 Files

Subscribers

guest-patmaddox

Details

Reviewers

Group Reviewers

Commits

rG91a6bf215cb1: kyua: Try harder to delete directories.
rGa7b4e2e9d0ca: kyua: Try harder to delete directories.
rG9bf14f2a475e: kyua: Try harder to delete directories.

Summary

When recursing into a directory to delete it, start by chmod'ing it to
0700. This fixes an issue where kyua is able to run, but not debug, a
test case that creates unwriteable directories, because when debugging
it tries (and fails) to delete the directory after the test completes.

This includes a test case which I haven't been able to test since we
don't build or install kyua's own tests.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65307
Build 62190: arc lint + arc unit

Event Timeline

des created this revision.Wed, Jul 9, 7:54 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 9, 7:54 PM

des requested review of this revision.Wed, Jul 9, 7:54 PM

Harbormaster completed remote builds in B65307: Diff 158235.Wed, Jul 9, 7:54 PM

fix test

Harbormaster completed remote builds in B65310: Diff 158238.Wed, Jul 9, 8:14 PM

tybo

Harbormaster completed remote builds in B65311: Diff 158239.Wed, Jul 9, 8:21 PM

LGTM. And I had a successful testing on my side.

This revision is now accepted and ready to land.Wed, Jul 9, 8:26 PM

Closed by commit rG9bf14f2a475e: kyua: Try harder to delete directories. (authored by des). · Explain WhyWed, Jul 9, 8:29 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG9bf14f2a475e: kyua: Try harder to delete directories..

guest-patmaddox added a subscriber: guest-patmaddox.Thu, Jul 10, 12:48 AM

des added a commit: rGa7b4e2e9d0ca: kyua: Try harder to delete directories..Thu, Jul 24, 1:02 PM

des added a commit: rG91a6bf215cb1: kyua: Try harder to delete directories..

Revision Contents
Changeset List

Path

Size

contrib/

kyua/

utils/

fs/

2 lines

operations_test.cpp

14 lines

Diff 158235

contrib/kyua/utils/fs/operations.cpp

Loading...

contrib/kyua/utils/fs/operations_test.cpp

Loading...