Differential D51116

Features/ssp.mk: Do not pass -fstack-protector as LDFLAGS
ClosedPublic
Actions

Authored by arrowd on Tue, Jul 1, 4:38 PM.

Details

Reviewers

bapt

Group Reviewers

portmgr

Commits

R11:4691740c69fa: Features/ssp.mk: Do not pass -fstack-protector as LDFLAGS

Summary

This isn't really a linker flag and worked only because C/C++ compiler is
usually used as linker.

This is backed by my own study of LLVM's code as well as this reply from
Flang's dev: https://discourse.llvm.org/t/flang-working-as-linker/87133/5

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 65161
Build 62044: arc lint + arc unit

Event Timeline

arrowd requested review of this revision.Tue, Jul 1, 4:38 PM

arrowd created this revision.

Harbormaster completed remote builds in B65161: Diff 157800.Tue, Jul 1, 4:38 PM

arrowd added a reviewer: portmgr.Tue, Jul 1, 4:38 PM

bapt accepted this revision.Wed, Jul 2, 7:16 AM

This revision is now accepted and ready to land.Wed, Jul 2, 7:16 AM

Closed by commit R11:4691740c69fa: Features/ssp.mk: Do not pass -fstack-protector as LDFLAGS (authored by arrowd). · Explain WhyWed, Jul 2, 2:58 PM

This revision was automatically updated to reflect the committed changes.

arrowd added a commit: R11:4691740c69fa: Features/ssp.mk: Do not pass -fstack-protector as LDFLAGS.

Revision Contents
Changeset List

Path

Size

Mk/

Features/

ssp.mk

1 line

Diff 157800

View Options

Features/ssp.mk: Do not pass -fstack-protector as LDFLAGSClosedPublicActions