dns/dnssec-rr/Makefile
4	Please grep the ports tree to see how this is handled in general however in this case upstream provides a release archive, https://git.sr.ht/~mcf/dnssec-rr/refs/0.2 --> https://git.sr.ht/~mcf/dnssec-rr/refs/download/0.2/dnssec-rr-0.2.tar.gz --> `MASTER_SITES= https://git.sr.ht/~mcf/dnssec-rr/refs/download/${DISTVERSION}/`
5	See above and having a distfile that's called 0.2.tar.gz in root dir is a no go This can be removed if you use upstream's release archive
16	Builds fine without gmake?
18	Not needed? See https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n439 and https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n78
25	manpages should go into share/man https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n2758
32	This seems overly complex, why not something like the following? do-install: .for i in dnskey ds nsec rrsig tlsa ${INSTALL_PROGRAM} ${WRKSRC}/${i} ${STAGEDIR}${PREFIX}/bin ${INSTALL_MAN} ${WRKSRC}/*.1 ${STAGEDIR}${PREFIX}/share/man/man1 .endfor

diizzy added inline comments.Sun, Jun 22, 2:00 AM

dns/dnssec-rr/Makefile
32	Actually I managed to botch the INSTALL_MAN line, it should say: `${INSTALL_MAN} ${WRKSRC}/${i}.1 ${STAGEDIR}${PREFIX}/share/man/man1` Sorry about that

incorporate diizzy feedback

Harbormaster completed remote builds in B65016: Diff 157422.Sun, Jun 22, 11:41 AM

updated with changes, thanks.

dns/dnssec-rr/Makefile

good, with the change above that works nicely now.

woops - thanks!

I found out *why* this needed the GZIP. As soon as I used
MANDIRS as target, they get automatically gzipped as expected.

/usr/local/bin/dnskey
/usr/local/bin/ds
/usr/local/bin/nsec
/usr/local/bin/rrsig
/usr/local/bin/tlsa
/usr/local/share/doc/dnssec-rr/README.md
/usr/local/share/licenses/dnssec-rr-0.2/ISCL
/usr/local/share/licenses/dnssec-rr-0.2/LICENSE
/usr/local/share/licenses/dnssec-rr-0.2/catalog.mk
/usr/local/share/man/man1/dnskey.1.gz
/usr/local/share/man/man1/ds.1.gz
/usr/local/share/man/man1/nsec.1.gz
/usr/local/share/man/man1/rrsig.1.gz
/usr/local/share/man/man1/tlsa.1.gz

better.

dch requested review of this revision.Sun, Jun 22, 11:41 AM

dch marked an inline comment as done.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jun 24, 8:34 AM

Closed by commit R11:2b7eb930adea: dns/dnssec-rr: new port - a DNSSEC toolkit written in C (authored by dch). · Explain Why

This revision was automatically updated to reflect the committed changes.

dch added a commit: R11:2b7eb930adea: dns/dnssec-rr: new port - a DNSSEC toolkit written in C.