Sponsored by: SkunkWerks, GmbH
Details
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 65015 Build 61898: arc lint + arc unit
Event Timeline
| dns/dnssec-rr/Makefile | ||
|---|---|---|
| 36 | it seems necessary to GZIP these before install, the following did not work: ${INSTALL_MAN} ${WRKSRC}/$i.1 \
${STAGEDIR}${PREFIX}/man/man1 | |
| dns/dnssec-rr/Makefile | ||
|---|---|---|
| 4 | Please grep the ports tree to see how this is handled in general however in this case upstream provides a release archive, https://git.sr.ht/~mcf/dnssec-rr/refs/0.2 --> https://git.sr.ht/~mcf/dnssec-rr/refs/download/0.2/dnssec-rr-0.2.tar.gz --> MASTER_SITES= https://git.sr.ht/~mcf/dnssec-rr/refs/download/${DISTVERSION}/ | |
| 5 | See above and having a distfile that's called 0.2.tar.gz in root dir is a no go | |
| 16 | Builds fine without gmake? | |
| 18 | ||
| 25 | manpages should go into share/man | |
| 32 | This seems overly complex, why not something like the following? do-install:
.for i in dnskey ds nsec rrsig tlsa
${INSTALL_PROGRAM} ${WRKSRC}/${i} ${STAGEDIR}${PREFIX}/bin
${INSTALL_MAN} ${WRKSRC}/*.1 ${STAGEDIR}${PREFIX}/share/man/man1
.endfor | |
| dns/dnssec-rr/Makefile | ||
|---|---|---|
| 32 | Actually I managed to botch the INSTALL_MAN line, it should say: | |
updated with changes, thanks.
| dns/dnssec-rr/Makefile | ||
|---|---|---|
| 18 | good, with the change above that works nicely now. | |
| 25 | woops - thanks! | |
| 32 | I found out *why* this needed the GZIP. As soon as I used /usr/local/bin/dnskey /usr/local/bin/ds /usr/local/bin/nsec /usr/local/bin/rrsig /usr/local/bin/tlsa /usr/local/share/doc/dnssec-rr/README.md /usr/local/share/licenses/dnssec-rr-0.2/ISCL /usr/local/share/licenses/dnssec-rr-0.2/LICENSE /usr/local/share/licenses/dnssec-rr-0.2/catalog.mk /usr/local/share/man/man1/dnskey.1.gz /usr/local/share/man/man1/ds.1.gz /usr/local/share/man/man1/nsec.1.gz /usr/local/share/man/man1/rrsig.1.gz /usr/local/share/man/man1/tlsa.1.gz better. | |