Only count CPU devices that are using the ACPI CPU driver.
ClosedPublic
Actions

Authored by jhb on Apr 27 2016, 4:45 PM.

Details

Reviewers

zbb
mst_semihalf.com

Commits

rS298754: Only count CPU devices that are using the ACPI CPU driver.

Summary

Only count CPU devices that are using the ACPI CPU driver.

Arguably we should only be doing the probe/attach to children of
these devices as well.

Test Plan

I've booted an x86 machine with ACPI and confirmed no regressions, but testing this on arm64 would verify it fixes the reported issue.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 15670.Apr 27 2016, 4:45 PM

jhb retitled this revision from to Only count CPU devices that are using the ACPI CPU driver..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: zbb.

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2016, 4:45 PM

jhb added a reviewer: mst_semihalf.com.Apr 27 2016, 5:56 PM

Hi, just tested this on arm64 and it fixes the error messages and the kernel panic. We can now add acpi back to arm64/GENERIC configuration. Thanks!

Closed by commit rS298754: Only count CPU devices that are using the ACPI CPU driver. (authored by jhb). · Explain WhyApr 28 2016, 6:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

acpica/

acpi_cpu.c

3 lines

Diff 15707

View Options

head/sys/dev/acpica/acpi_cpu.c

Only count CPU devices that are using the ACPI CPU driver.ClosedPublicActions