Differential D50350

devel/py-pyopencl: Pass nullptr instead of NULL to unique_ptr constructor
ClosedPublic
Actions

Authored by jhb on Wed, May 14, 3:02 PM.

Details

Reviewers

lwhsu

Group Reviewers

Python

Commits

R11:ffeff2e54504: devel/py-pyopencl: Pass nullptr instead of NULL to unique_ptr constructor

Summary

This applies upstream commit bf3cb670f30bc2c5dfec102b147b41146381d769.

PR: 286476

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64174
Build 61058: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Wed, May 14, 3:02 PM

jhb created this revision.

Harbormaster completed remote builds in B64174: Diff 155449.Wed, May 14, 3:02 PM

This could also be fixed by updating to a newer version, but that involves other change as it doesn't build the same, etc. so I punted on that. The latest release is 2025.1, so the port is about 7 years out of date.

jhb added a child revision: D50089: Don't define NULL to nullptr in C++11 mode.Wed, May 14, 4:24 PM

lwhsu accepted this revision.Thu, May 15, 3:44 AM

This revision is now accepted and ready to land.Thu, May 15, 3:44 AM

Closed by commit R11:ffeff2e54504: devel/py-pyopencl: Pass nullptr instead of NULL to unique_ptr constructor (authored by jhb). · Explain WhyFri, May 30, 11:21 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: R11:ffeff2e54504: devel/py-pyopencl: Pass nullptr instead of NULL to unique_ptr constructor.

Revision Contents
Changeset List

Path

Size

devel/

py-pyopencl/

Makefile

2 lines

files/

patch-src_wrap__constants.cpp

11 lines

Diff 155449

View Options

devel/py-pyopencl/Makefile