www/webkit2-gtk: properly expose roundeven{,f} on 32-bit platforms
ClosedPublic
Actions

Authored by vishwin on May 3 2025, 5:34 PM.

Details

Reviewers

fuz
makc
dinoex

Group Reviewers

gnome

Commits

R11:444288f101a2: www/webkit2-gtk: properly expose roundeven{,f} on 32-bit platforms
R11:c467c7498ddf: www/webkit2-gtk: properly expose roundeven{,f} on 32-bit platforms

Summary

The preprocessor guard only accounts for Linux without glibc, but we don't have these C23 functions yet either.

Test Plan

test on 32-bit platforms

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 63859
Build 60743: arc lint + arc unit

Event Timeline

vishwin requested review of this revision.May 3 2025, 5:34 PM

vishwin created this revision.

Harbormaster completed remote builds in B63859: Diff 154756.May 3 2025, 5:34 PM

Builds fine on 14.2-RELEASE-p3, thanks!

This revision is now accepted and ready to land.May 3 2025, 7:38 PM

Please make sure to MFH this change when it lands. My test builds on armv7 and i386 are still ongoing.

dinoex accepted this revision.May 4 2025, 7:40 AM

Build test on i386 and armv7 FreeBSD 14.2 passed.

Closed by commit R11:c467c7498ddf: www/webkit2-gtk: properly expose roundeven{,f} on 32-bit platforms (authored by vishwin). · Explain WhyMay 4 2025, 12:37 PM

This revision was automatically updated to reflect the committed changes.

vishwin added a commit: R11:c467c7498ddf: www/webkit2-gtk: properly expose roundeven{,f} on 32-bit platforms.

vishwin added a commit: R11:444288f101a2: www/webkit2-gtk: properly expose roundeven{,f} on 32-bit platforms.May 4 2025, 12:40 PM

Revision Contents
Changeset List

Path

Size

www/

webkit2-gtk/

files/

patch-Source_JavaScriptCore_runtime_MathCommon.cpp

11 lines

Diff 154756

View Options

www/webkit2-gtk/files/patch-Source_JavaScriptCore_runtime_MathCommon.cpp

www/webkit2-gtk: properly expose roundeven{,f} on 32-bit platformsClosedPublicActions