Details
Details
- Reviewers
gerald salvadore - Commits
- R11:3ae2d2f686fd: lang/clisp: Build with system compiler
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 63826 Build 60710: arc lint + arc unit
Event Timeline
Comment Actions
Nice, thank you!
I made one specific comment re the LDFLAGS magic that predates your changes (this one and the ones in the last half year) and which I believe can be removed as well.
For the sake of completeness: Seeing how this now builds with clang, even should GCC be required for some reason yet unknown, -fpermissive should not be required any longer.
| lang/clisp/Makefile | ||
|---|---|---|
| 38–39 | I believe these two can go as well. They were added with revision 511d74702f779 commit 511d74702f7790d4938c55a5b80a2b73f18297d0 lang/clisp: fix build with GCC-based architectures Add -lthr to LDFLAGS on GCC architectures. While here, also add USES=localbase:ldflags. PR: 237524 and I do not think we have GCC architectures left. Plus with you removing USES=compiler, $CHOSEN_COMPILER_TYPE won't be defined any longer, so these two lines become noops anyway? | |