java/openjdk24: Upgrade to version 24.0.1
ClosedPublic
Actions

Authored by haraldei_anduin.net on Apr 24 2025, 10:33 AM.

Details

Reviewers

emaste
jrm
glewis

Commits

R11:5fc04e4b900f: java/openjdk24: Upgrade to version 24.0.1+9.1

Summary

Upgrade openjdk24 port to OpenJDK 24.0.1

Test Plan

Run the test-tier1 makefile target in the source repo
Test GUI programs (OWASP ZAP, TuxGuitar, ...)
Test basic Tomcat

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 63696
Build 60580: arc lint + arc unit

Event Timeline

haraldei_anduin.net requested review of this revision.Apr 24 2025, 10:33 AM

haraldei_anduin.net created this revision.

Harbormaster completed remote builds in B63693: Diff 154203.Apr 24 2025, 10:33 AM

java/openjdk24: Remove os_bsd_ppc patch

Harbormaster completed remote builds in B63696: Diff 154207.Apr 24 2025, 11:53 AM

emaste added inline comments.Apr 24 2025, 12:47 PM

java/openjdk24/Makefile
6	Why does the PORTREVISION get bumped? The version already includes the JDK_PATCH_VERSION which I'd think is enough?

Builds and installs fine on AMD64 and Aarch64. Waiting for feedback on PPC.

haraldei_anduin.net added inline comments.Apr 24 2025, 1:03 PM

java/openjdk24/Makefile
6	Was a bit unsure about that, but thought that since it's the same port, but with a new version it was required? Happy to revert it if that's not the case.

java/openjdk24: Don't bump portrevision

Harbormaster completed remote builds in B63699: Diff 154215.Apr 24 2025, 1:43 PM

haraldei_anduin.net marked an inline comment as done.Apr 24 2025, 1:43 PM

jrm added inline comments.Apr 24 2025, 2:00 PM

java/openjdk24/Makefile
6	It doesn't need to be bumped because `DISTVERSION` is increasing, which will trigger a package upgrade for users. % pkg version -t openjdk24-24.0.0+36.1 openjdk24-24.0.1+9.1 < Bumping `PORTREVISION` is a way to trigger an upgrade when there are important changes to the port/package, but the version doesn't increase. Details: https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming-revepoch

LGTM

This revision is now accepted and ready to land.Apr 24 2025, 2:03 PM

emaste accepted this revision.Apr 24 2025, 2:10 PM

Harald, did you run it through poudriere? If not, I have some builds running now and can report back soon.

https://pkg.ftfl.ca/build.html?mastername=14amd64-default&build=2025-04-24_11h21m57s

Poudriere builds look good. Harald, please let me know if you're satisfied with all your run-time tests, and I'll commit.

In D49996#1140454, @jrm wrote:

Poudriere builds look good. Harald, please let me know if you're satisfied with all your run-time tests, and I'll commit.

Apart from jsvc (devel/apache-domcat-daemon) still not working on Aarch64, all my other tests look good. Tomcat itself works fine if started directly.

I've only tested the GUI apps on X86_64.

I think this is at least as good as the initial openjdk24 port.

Closed by commit R11:5fc04e4b900f: java/openjdk24: Upgrade to version 24.0.1+9.1 (authored by haraldei_anduin.net, committed by jrm). · Explain WhyApr 25 2025, 3:27 PM

This revision was automatically updated to reflect the committed changes.

jrm added a commit: R11:5fc04e4b900f: java/openjdk24: Upgrade to version 24.0.1+9.1.