Page MenuHomeFreeBSD
Differential D48431

[NEW-PORT] comms/py-sdm_modbus: Library for Eastron SDM kWh meters
ClosedPublic
Actions

Authored by kiwi on Jan 11 2025, 5:30 PM.
Tags
None
Referenced Files
F125497696: D48431.diff
Fri, Aug 8, 10:13 AM
Unknown Object (File)
Sat, Aug 2, 8:49 PM
Unknown Object (File)
Sat, Aug 2, 3:06 PM
Unknown Object (File)
Fri, Aug 1, 10:22 PM
Unknown Object (File)
Thu, Jul 31, 10:25 PM
Unknown Object (File)
Wed, Jul 30, 10:50 AM
Unknown Object (File)
Mon, Jul 28, 12:17 AM
Unknown Object (File)
Sun, Jul 27, 5:03 AM
View All 85 Files
Subscribers
None

Details

Reviewers
0mp
Commits
R11:e0323e9ffb66: comms/py-sdm_modbus: Library for Eastron SDM kWh meters
Summary
comms/py-sdm_modbus: Library for Eastron SDM kWh meters

Library that collects data from Eastron SDM single and three phase kWh
meters over Modbus RTU or Modbus TCP

Approved by: 0mp (mentor)
Test Plan

Tested with python 3.11 on FreeBSD 14.2 with some modbus TCP Eastron Meters.
Pet portlint/portclippy
Poudriere test on 14.2

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kiwi requested review of this revision.Jan 11 2025, 5:30 PM
kiwi created this revision.
0mp requested changes to this revision.Jan 13 2025, 3:43 PM
0mp added inline comments.
comms/py-sdm_modbus/Makefile
3

Please use DISTVERSION by default. Only use PORTVERSION if necessary.

comms/py-sdm_modbus/pkg-descr
3
This revision now requires changes to proceed.Jan 13 2025, 3:43 PM
kiwi updated this revision to Diff 149188.Jan 13 2025, 3:59 PM
kiwi marked 2 inline comments as done.

Added suggested changes

0mp added a comment.Jan 14 2025, 1:30 PM

One more question before we land it :)

comms/py-sdm_modbus/Makefile
19

BTW, is this one necessary?

kiwi added a comment.Jan 24 2025, 3:06 PM
In D48431#1105468, @0mp wrote:

One more question before we land it :)

Well after tests, this is not necessary, update will come soon

kiwi marked an inline comment as done.Jan 24 2025, 5:29 PM

Removed

kiwi updated this revision to Diff 149931.Jan 24 2025, 5:32 PM

Removed DOCSDIRS

0mp added a comment.Feb 7 2025, 4:40 PM

Looks almost perfect. Two small bits left then it's ready to land.

comms/py-sdm_modbus/Makefile
3

DISTVERSION is preferred to PORTREVISION.

https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-versions

comms/py-sdm_modbus/pkg-descr
3

The period is still missing.

kiwi updated this revision to Diff 150687.Feb 7 2025, 4:56 PM

Use DISTVERSION
Added missing dot at end of pkg-descr

kiwi marked 2 inline comments as done.Feb 7 2025, 4:56 PM

All requested bits has been done !

0mp accepted this revision.Feb 7 2025, 4:57 PM

Ship it!

This revision is now accepted and ready to land.Feb 7 2025, 4:57 PM
Closed by commit R11:e0323e9ffb66: comms/py-sdm_modbus: Library for Eastron SDM kWh meters (authored by kiwi). · Explain WhyFeb 7 2025, 5:00 PM
This revision was automatically updated to reflect the committed changes.
kiwi added a commit: R11:e0323e9ffb66: comms/py-sdm_modbus: Library for Eastron SDM kWh meters.

Revision Contents
Changeset List

PathSize
comms/
1 line
py-sdm_modbus/
22 lines
3 lines
2 lines

Diff 150687

View Options

comms/Makefile

Loading...
View Options

comms/py-sdm_modbus/Makefile

Loading...
View Options

comms/py-sdm_modbus/distinfo

Loading...
View Options

comms/py-sdm_modbus/pkg-descr

Loading...