lang/rust: unbreak build on gcc platforms
ClosedPublic
Actions

Authored by jbeich on Apr 10 2016, 1:51 AM.

Details

Reviewers

riggs

Commits

rP413501: Update to upstream version 1.8.0

Summary

GCC isn't default on all platforms FreeBSD supports, and some users may have defined FAVORITE_COMPILER=gcc via make.conf(5) or Makefile.local.

$ make
[...]
g++5: error: unrecognized command line option '-stdlib=libc++'

Test Plan

$ make -V CONFIGURE_ARGS CHOSEN_COMPILER_TYPE=""
--disable-valgrind --disable-docs    --mandir=/usr/local/man  --release-channel=stable

$ make -V CONFIGURE_ARGS CHOSEN_COMPILER_TYPE=gcc
--disable-valgrind --disable-docs    --mandir=/usr/local/man  --release-channel=stable

$ make -V CONFIGURE_ARGS CHOSEN_COMPILER_TYPE=clang
--disable-valgrind --disable-docs  --enable-clang  --mandir=/usr/local/man  --release-channel=stable

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 3194
Build 3227: arc lint + arc unit

Event Timeline

jbeich updated this revision to Diff 15047.Apr 10 2016, 1:51 AM

jbeich retitled this revision from to lang/rust: unbreak build on gcc platforms.

jbeich updated this object.

jbeich edited the test plan for this revision. (Show Details)

jbeich added a reviewer: riggs.

Herald added a subscriber: mat. · View Herald TranscriptApr 10 2016, 1:51 AM

I am testing an update to rust 1.8.0 at the moment.
@jbeich if you want, you can commit this right away (could you use / instead of @ inside the variable modifier to match the rest of the port?), otherwise I'll include it when I am happy with the 1.8.0 update, hopefully tomorrow morning

This revision is now accepted and ready to land.Apr 16 2016, 8:19 PM

Closed by commit rP413501: Update to upstream version 1.8.0 (authored by riggs). · Explain WhyApr 17 2016, 10:21 AM

This revision was automatically updated to reflect the committed changes.

riggs mentioned this in rP413501: Update to upstream version 1.8.0.