Differential D48425

nextboot: Smarter warning about deleting nextboot
ClosedPublic
Actions

Authored by imp on Sat, Jan 11, 5:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 23, 1:45 AM

	Unknown Object (File)
	Fri, Jan 17, 8:35 AM

	Unknown Object (File)
	Thu, Jan 16, 12:21 PM

	Unknown Object (File)
	Thu, Jan 16, 8:10 AM

	Unknown Object (File)
	Thu, Jan 16, 3:08 AM

	Unknown Object (File)
	Tue, Jan 14, 9:12 PM

	Unknown Object (File)
	Sun, Jan 12, 6:18 PM

Subscribers

Details

Reviewers: None
Commits: rGbec5a3c046ba: nextboot: Smarter warning about deleting nextboot

Summary

Read only filesystems always error when trying to remove something
with EROFS. However, that's true even if the file isn't there. The
code assumed it would always get a ENOENT if the file wasn't there,
but produced a gross message on read only systems. This message was
harmless, but annoying. Instead, stat the file first and return if
it's already not there.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61672
Build 58556: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sat, Jan 11, 5:45 AM

imp created this revision.

Herald added a subscriber: cy. · View Herald TranscriptSat, Jan 11, 5:45 AM

Harbormaster completed remote builds in B61672: Diff 149123.Sat, Jan 11, 5:45 AM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jan 14, 5:54 PM

Closed by commit rGbec5a3c046ba: nextboot: Smarter warning about deleting nextboot (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGbec5a3c046ba: nextboot: Smarter warning about deleting nextboot.

Revision Contents
Changeset List

Path

Size

sbin/

reboot/

15 lines

Diff 149123

sbin/reboot/reboot.c

Loading...