Page MenuHomeFreeBSD

lang/ruby34: Add new port
Needs ReviewPublic

Authored by yasu on May 18 2024, 7:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 12:35 AM
Unknown Object (File)
Nov 24 2024, 3:54 AM
Unknown Object (File)
Nov 11 2024, 3:35 PM
Unknown Object (File)
Oct 3 2024, 9:39 AM
Unknown Object (File)
Oct 1 2024, 2:43 PM
Unknown Object (File)
Sep 28 2024, 10:41 AM
Unknown Object (File)
Sep 25 2024, 10:02 PM
Unknown Object (File)
Sep 9 2024, 6:47 PM
Subscribers

Details

Summary
Test Plan
  • Build succeeds with poudriere and 14.0-RELEASE amd64 jail.
  • Pass check of portlint, portclippy and portfmt.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 61354
Build 58238: arc lint + arc unit

Event Timeline

yasu requested review of this revision.May 18 2024, 7:47 AM
yasu created this revision.
diizzy added inline comments.
lang/ruby34/Makefile
19

${LOCALBASE} in LIB_DEPENDS in doesn't work?

41

I guess this falls under style preference but for consistency and logical reasons I'd place these variables before CONFIGURE_ARGS

44

Should be formatted so it's readable?

lang/ruby34/Makefile
19

Do you mean such line as below?

LIB_DEPENDD= ${LOCALBASE}/lib/libffi.so:devel/libffi

If so, unfortunately it doesn't.

41

Order of variables in Makefile is sorted with portclippy.

44

It is formatted with portfmt.

lang/ruby34/Makefile
41

I would argue that some are logically incorrect but it is what it is :-)

44

It's much harder to read (follow) than

--exclude ${DISTNAME}/bin/gem \
--exclude ${DISTNAME}/ext/win32* \
--exclude ${DISTNAME}/lib/bundler* \

....and so on?