Page MenuHomeFreeBSD
Differential D5775

Hide .cerror, .curbrk, .minbrk on WITHOUT_SYMVER arm64
ClosedPublic
Actions

Authored by emaste on Mar 29 2016, 5:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 2:01 AM
Unknown Object (File)
Fri, Nov 21, 1:56 AM
Unknown Object (File)
Fri, Nov 21, 1:55 AM
Unknown Object (File)
Fri, Nov 21, 1:54 AM
Unknown Object (File)
Mon, Nov 17, 5:53 AM
Unknown Object (File)
Sun, Nov 16, 3:34 PM
Unknown Object (File)
Thu, Nov 13, 7:41 PM
Unknown Object (File)
Thu, Nov 13, 1:10 PM
View All 96 Files
Subscribers
None

Details

Reviewers
andrew
Commits
rS297973: arm64 libc: hide .cerror, .curbrk, .minbrk for WITHOUT_SYMVER
Summary

When symver is in use these are hidden because they're not listed in the Symbol.map. Add an explicit .hidden so they are also hidden in the WITHOUT_SYMVER case.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 14717.Mar 29 2016, 5:39 PM
emaste retitled this revision from to Hide .cerror, .curbrk, .minbrk on WITHOUT_SYMVER arm64.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: andrew.
emaste added a comment.Apr 13 2016, 4:26 PM

Akin to D5571 / rS296474 for amd64 and i386.

lib/libc/aarch64/sys/cerror.S
32

This will be corrected to .hidden cerror

andrew accepted this revision.Apr 14 2016, 10:24 AM
andrew edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 10:24 AM
Closed by commit rS297973: arm64 libc: hide .cerror, .curbrk, .minbrk for WITHOUT_SYMVER (authored by emaste). · Explain WhyApr 14 2016, 5:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
sys/
1 line
1 line
1 line

Diff 14717

View Options

lib/libc/aarch64/sys/brk.S

Loading...
View Options

lib/libc/aarch64/sys/cerror.S

Loading...
View Options

lib/libc/aarch64/sys/sbrk.S

Loading...