Details
- Reviewers
- None
- Commits
- rP411931: What is Citus?
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 3003 Build 3033: arc lint + arc unit
Event Timeline
| databases/pg_citus/Makefile | ||
|---|---|---|
| 17 | This should be DISTVERSIONPREFIX=v in the top block. | |
Testbuilds on 9.3a, 10.2i failed to build:
http://people.freebsd.org/~pi/logs/databases__pg_citus-10i-1458896575.txt
http://people.freebsd.org/~pi/logs/databases__pg_citus-93a-1458896575.txt
| databases/pg_citus/Makefile | ||
|---|---|---|
| 8 | This should be between PORTVERSION and CATEGORIES. portlint should have told you that. | |
Using both the INT64CONST() macro and suffixing a constant value with
'UL' breaks compilation on systems where HAVE_LL_CONSTANTS is defined
in ${LOCALBASE}/include/postgresql/server/pg_config.h (ie. i386
machines)
Note that your local setup seems to be adding svn:keywords=Author Date Id Rev URL to all the files, it'll need to be fixed before commit :-)
| databases/pg_citus/Makefile | ||
|---|---|---|
| 7 | there may be missing a <tab> here. | |
Hmmm... I've now removed the svn:keywords bits from my subversion config. I used to use it for some projects long since migrated to git. Anyhow, I plan to use ${PORTSDIR}/Tools/scripts/addport to actually do the commit, so that wouldn't be a problem in any case.