Page MenuHomeFreeBSD
Differential D46752

[hb]: Update instructions to update from source
Needs ReviewPublic
Actions

Authored by fernape on Sep 22 2024, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 19, 6:53 PM
Unknown Object (File)
Fri, Jan 17, 11:11 PM
Unknown Object (File)
Fri, Jan 17, 1:14 PM
Unknown Object (File)
Wed, Jan 15, 5:32 PM
Unknown Object (File)
Wed, Jan 15, 5:09 PM
Unknown Object (File)
Wed, Jan 8, 12:56 AM
Unknown Object (File)
Dec 3 2024, 5:09 AM
Unknown Object (File)
Nov 21 2024, 3:57 PM
View All 28 Files
Subscribers
jhb

Details

Reviewers
None
Group Reviewers
Src Committers
Summary

Add instructions to delete old files and libraries as documented in the top
level Makefile of src.

Test Plan
  • Apply patch
  • make run
  • Access localhost:1313 and inspect the relevant section of the handbook

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 59761
Build 56647: arc lint + arc unit

Event Timeline

fernape requested review of this revision.Sep 22 2024, 5:58 PM
fernape created this revision.
Harbormaster completed remote builds in B59563: Diff 143624.Sep 22 2024, 5:58 PM
fernape added a reviewer: Src Committers.Sep 22 2024, 6:01 PM
fernape updated this revision to Diff 144262.Oct 4 2024, 4:04 PM

Fix typo

Harbormaster completed remote builds in B59761: Diff 144262.Oct 4 2024, 4:04 PM
jhb added a subscriber: jhb.Oct 21 2024, 3:07 PM
jhb added inline comments.
documentation/content/en/books/handbook/cutting-edge/_index.adoc
738

This is fine (and matches UPDATING)

740

I don't think we want to add this blindly. In UPDATING, the comment for make delete-old mentions make delete-old-libs and explains when it is safe to run. I think you should mirror that arrangement here.

764
fernape added inline comments.Tue, Jan 7, 12:31 PM
documentation/content/en/books/handbook/cutting-edge/_index.adoc
764

Isn't this warning the same as the comment in line 768 for make delete-old-libs

fernape updated this revision to Diff 148865.Tue, Jan 7, 12:57 PM
  • [hb]: Warn about blindly removing old libraries

    As suggested by jhb@
Harbormaster completed remote builds in B61539: Diff 148865.Tue, Jan 7, 12:57 PM
jhb added inline comments.Thu, Jan 9, 4:22 PM
documentation/content/en/books/handbook/cutting-edge/_index.adoc
764

I pulled this text directly from src/UPDATING from footnote 6 at the end of the file where it talks about this same general topic (general steps for upgrading from source)

fernape added inline comments.Mon, Jan 13, 5:26 PM
documentation/content/en/books/handbook/cutting-edge/_index.adoc
764

The bullet list already has the warning (rephrased, more compact) and then the description list also includes a similar clarification.
I'm not sure if you mean that in the bullet list you want the whole comment.

Thanks!

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
handbook/
cutting-edge/
6 lines

Diff 144262

View Options

documentation/content/en/books/handbook/cutting-edge/_index.adoc

Loading...