Page MenuHomeFreeBSD
Differential D5608

- Update pimd to 2.3.2 - This fix the build on i386 - Thanks to hrs@ for his patch
ClosedPublic
Actions

Authored by olivier on Mar 11 2016, 8:45 AM.
Tags
None
Referenced Files
F151699290: D5608.id14235.diff
Fri, Apr 10, 2:49 AM
Unknown Object (File)
Mon, Mar 30, 5:13 PM
Unknown Object (File)
Mon, Mar 30, 3:02 AM
Unknown Object (File)
Sun, Mar 29, 7:50 PM
Unknown Object (File)
Sat, Mar 28, 1:12 PM
Unknown Object (File)
Sat, Mar 28, 8:52 AM
Unknown Object (File)
Thu, Mar 26, 6:42 PM
Unknown Object (File)
Wed, Mar 25, 9:14 AM
View All Files
Subscribers
mat

Details

Reviewers
tabthorpe
jadawin
Commits
rP410830: - Update to 2.3.2
Summary

poudriere testport logs

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2851
Build 2875: arc lint + arc unit

Event Timeline

olivier updated this revision to Diff 14231.Mar 11 2016, 8:45 AM
olivier retitled this revision from to - Update pimd to 2.3.2 - This fix the build on i386 - Thanks to hrs@ for his patch.
olivier updated this object.
olivier edited the test plan for this revision. (Show Details)
olivier added reviewers: jadawin, tabthorpe.
Herald added a subscriber: mat. · View Herald TranscriptMar 11 2016, 8:45 AM
mat added inline comments.Mar 11 2016, 10:49 AM
net/pimd/Makefile
15

You don't need to add ${PORTNAME} here, it is the default.

24–26
  1. ${WRKDIR}/libite-1.4.4 is called ${WRKSRC_libite} https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-multiple
  1. the current trend is to move the directories, not create symlinks. https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-multi
olivier updated this revision to Diff 14234.Mar 11 2016, 12:55 PM

update patch following mat comments

  1. Updating D5608: - Update pimd to 2.3.2
  2. This fix the build on i386
  3. Thanks to hrs@ for his patch
olivier updated this revision to Diff 14235.Mar 11 2016, 12:56 PM

Oops, forgot to remove a commented line

  1. Updating D5608: - Update pimd to 2.3.2
  2. This fix the build on i386
  3. Thanks to hrs@ for his patch
jadawin accepted this revision.Mar 11 2016, 1:56 PM
jadawin edited edge metadata.

Approved. thanks mat for comments.

This revision is now accepted and ready to land.Mar 11 2016, 1:56 PM
Closed by commit rP410830: - Update to 2.3.2 (authored by olivier). · Explain WhyMar 11 2016, 2:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
net/
pimd/
13 lines
6 lines
files/
10 lines
1 line

Diff 14231

View Options

net/pimd/Makefile

Loading...
View Options

net/pimd/distinfo

Loading...
View Options

net/pimd/files/pimd.in

Loading...
View Options

net/pimd/pkg-plist

Loading...