net80211: remove redundant locking
ClosedPublic
Actions

Authored by avos on Feb 27 2016, 3:38 PM.

Details

Reviewers

Commits

rS296170: net80211: remove redundant locking.

Summary

<dev>_com_lock is already obtained when ieee80211_promisc()/ieee80211_allmulti() are called (from ieee80211_vap_detach() or ieee80211_ioctl() (without D5474: ap_start()/ap_end() are locked too and ap_cancel() is never called)).

Test Plan

Tested with (D5474 already applied):

Intel 3945BG, HOSTAP mode.
RTL8188EU, STA mode.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 13831.Feb 27 2016, 3:38 PM

avos retitled this revision from to net80211: remove redundant locking.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2016, 3:38 PM

heh, what did you test this on?

avos edited the test plan for this revision. (Show Details)Feb 27 2016, 6:16 PM

avos edited edge metadata.

adrian accepted this revision.Feb 28 2016, 8:36 AM

adrian edited edge metadata.

This revision is now accepted and ready to land.Feb 28 2016, 8:36 AM

Closed by commit rS296170: net80211: remove redundant locking. (authored by avos). · Explain WhyFeb 28 2016, 11:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211.c

8 lines

Diff 13831

View Options

net80211: remove redundant lockingClosedPublicActions