Page MenuHomeFreeBSD

databases/postgres_exporter: New port
ClosedPublic

Authored by jbo on Apr 20 2024, 9:54 PM.
Tags
None
Referenced Files
F170532952: D44888.id.diff
Sat, Sep 5, 6:57 AM
F170451752: D44888.id139150.diff
Fri, Sep 4, 9:44 PM
F170407610: D44888.id.diff
Fri, Sep 4, 4:44 PM
Unknown Object (File)
Fri, Sep 4, 6:30 AM
Unknown Object (File)
Wed, Sep 2, 11:07 AM
Unknown Object (File)
Tue, Sep 1, 10:21 PM
Unknown Object (File)
Mon, Aug 31, 10:22 AM
Unknown Object (File)
Tue, Aug 25, 1:19 PM
Subscribers
None

Details

Summary

PostgreSQL metric exporter for Prometheus.

PR: 276996

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57252
Build 54140: arc lint + arc unit

Event Timeline

jbo requested review of this revision.Apr 20 2024, 9:54 PM
jbo created this revision.

The section of the handbook you're referring to states:

If there is a very good reason not to install a working configuration file by default, only list the sample filename in pkg-plist, without the @sample followed by a space part, and add a message pointing out that the user must copy and edit the file before the software will work.

The configuration file consists pretty much only out of credentials and other user/installation specific information such as database names. The port cannot generate a working configuration file by default.
I'd argue that this is a very good reason :D

The pkg-message was has also been set:

A sample configuration file has been installed in
%%PREFIX%%/etc/postgres_exporter.yml.sample.

To use postgres_exporter, copy this config file to "postgres_exporter.yml"
and edit as needed, then enable and start the service:

Is there anything else keeping this from getting approved?

This revision is now accepted and ready to land.May 27 2024, 4:45 AM
This revision was automatically updated to reflect the committed changes.