Paths

Table of Contentst

Differential D44664

stdbool.h: Update for C23
AcceptedPublic
Actions

Authored by minsoochoo0122_proton.me on Apr 7 2024, 2:11 AM.

Tags

Referenced Files

	F108129450: D44664.diff
	Tue, Jan 21, 5:07 PM

	Unknown Object (File)
	Sat, Jan 11, 6:59 AM

	Unknown Object (File)
	Dec 6 2024, 2:30 PM

	Unknown Object (File)
	Sep 8 2024, 10:56 AM

	Unknown Object (File)
	Sep 6 2024, 3:41 AM

	Unknown Object (File)
	Sep 6 2024, 1:54 AM

	Unknown Object (File)
	Sep 5 2024, 6:49 PM

	Unknown Object (File)
	Sep 4 2024, 11:08 AM

View All 29 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

Group Reviewers

Contributor Reviews (src)

Summary

When a compiler with C23 or higher is detected, builtin bool, true,
and false are used to conform the C23 standard.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56952
Build 53840: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Apr 7 2024, 2:11 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2024, 2:11 AM

minsoochoo0122_proton.me requested review of this revision.Apr 7 2024, 2:11 AM

Harbormaster completed remote builds in B56948: Diff 136635.Apr 7 2024, 2:11 AM

minsoochoo0122_proton.me added a reviewer: Contributor Reviews (src).Apr 7 2024, 2:11 AM

minsoochoo0122_proton.me added a project: Contributor Reviews (src).

minsoochoo0122_proton.me added a subscriber: Contributor Reviews (src).

Add __STDC_VERSION_STDBOOL_H__ as the header file now conforms C23.

Harbormaster completed remote builds in B56949: Diff 136636.Apr 7 2024, 2:21 AM

imp requested changes to this revision.Apr 7 2024, 3:38 AM

imp added inline comments.

include/stdbool.h
30	This doesn't match normal header practice. I'd be tempted to just use #pragma once
48	Why?

This revision now requires changes to proceed.Apr 7 2024, 3:38 AM

minsoochoo0122_proton.me added inline comments.Apr 7 2024, 4:23 AM

include/stdbool.h
30	This doesn't match normal header practice. I'd be tempted to just use #pragma once C23 N3220 draft This is a version test macro that tells the current implmented C standard version of a header file. 7.1.2 (Standard Headers) 6: Some standard headers define or declare identifiers that had not been present in previous versions of this document. To allow implementations and users to adapt to that situation, they also define a version macro for feature test of the form `__STDC_VERSION_ XXXX_H__` which expands to 202311L, where XXXX is the all-caps spelling of the corresponding header <xxxx.h>.
48	Why? I wanted to make sure that those are keywords in C23 and c++, but now it seems redundant. I'll remove them.

Removed redundant macros

Harbormaster completed remote builds in B56952: Diff 136639.Apr 7 2024, 4:27 AM

minsoochoo0122_proton.me marked an inline comment as done.Apr 7 2024, 4:27 AM

OK. This looks ready to go then. Sorry for my slowness in responding

include/stdbool.h
30	This doesn't match normal header practice. I'd be tempted to just use #pragma once C23 N3220 draft This is a version test macro that tells the current implmented C standard version of a header file. 7.1.2 (Standard Headers) 6: Some standard headers define or declare identifiers that had not been present in previous versions of this document. To allow implementations and users to adapt to that situation, they also define a version macro for feature test of the form `__STDC_VERSION_ XXXX_H__` which expands to 202311L, where XXXX is the all-caps spelling of the corresponding header <xxxx.h>. Right. That makes sense now that I know it's the 'new standard' to do it like that.

This revision is now accepted and ready to land.Jun 3 2024, 5:06 PM

Revision Contents
Changeset List

Path

Size

include/

8 lines

Diff 136639

include/stdbool.h

Loading...