snd_hdspe(4): Only buffer_copy() audio data once.
ClosedPublic
Actions

Authored by dev_submerge.ch on Feb 26 2024, 12:49 AM.

Details

Reviewers

Commits

rGee36e7faceaf: snd_hdspe(4): Only buffer_copy() audio data once.

Summary

Instead of blindly copying two periods of audio data to and from DMA
buffers, keep track of the writing position and derive the actual
part of audio data that needs to be copied.
This approximately halves the number of samples copied in total.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56241
Build 53129: arc lint + arc unit

Event Timeline

dev_submerge.ch created this revision.Feb 26 2024, 12:49 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 26 2024, 12:49 AM

dev_submerge.ch requested review of this revision.Feb 26 2024, 12:49 AM

Harbormaster completed remote builds in B56241: Diff 134998.Feb 26 2024, 12:49 AM

I'm still testing this, but I haven't found any problems in the last few days. It's hard to tell whether this approach is robust against missed interrupts, because I never encountered any.

Ruslan, does the calculation of position and length look reasonable to you? We have to store the playback writing position extra because we don't set it in the sndbuf structure.

In D44084#1005680, @dev_submerge.ch wrote:

I'm still testing this, but I haven't found any problems in the last few days. It's hard to tell whether this approach is robust against missed interrupts, because I never encountered any.

Ruslan, does the calculation of position and length look reasonable to you? We have to store the playback writing position extra because we don't set it in the sndbuf structure.

looks ok to me, I have been testing this for about a week -- no issues

In D44084#1010276, @br wrote:

In D44084#1005680, @dev_submerge.ch wrote:

I'm still testing this, but I haven't found any problems in the last few days. It's hard to tell whether this approach is robust against missed interrupts, because I never encountered any.

Ruslan, does the calculation of position and length look reasonable to you? We have to store the playback writing position extra because we don't set it in the sndbuf structure.

looks ok to me, I have been testing this for about a week -- no issues