Page MenuHomeFreeBSD
Differential D5250

netfront: remove pointless assignment in xn_ioctl
ClosedPublic
Actions

Authored by liuw_liuw.name on Feb 11 2016, 11:39 AM.
Tags
None
Referenced Files
F137408897: D5250.diff
Sun, Nov 23, 4:32 AM
F137405146: D5250.id.diff
Sun, Nov 23, 3:36 AM
Unknown Object (File)
Fri, Nov 21, 3:11 PM
Unknown Object (File)
Fri, Nov 21, 2:58 AM
Unknown Object (File)
Wed, Nov 12, 1:05 PM
Unknown Object (File)
Wed, Nov 12, 9:32 AM
Unknown Object (File)
Wed, Nov 12, 9:32 AM
Unknown Object (File)
Wed, Nov 12, 5:55 AM
View All Files
Subscribers
imp

Details

Reviewers
royger
Commits
rS295510: xen-netfront: remove pointless assignment in xn_ioctl
Summary

The variable error is assigned to 0 before entering the switch.
Assigning error to 0 before break pointless rewrites the real error
value that should be returned.

This is CID 1304974.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

liuw_liuw.name updated this revision to Diff 13212.Feb 11 2016, 11:39 AM
liuw_liuw.name retitled this revision from to netfront: remove pointless assignment in xn_ioctl.
liuw_liuw.name updated this object.
liuw_liuw.name edited the test plan for this revision. (Show Details)
liuw_liuw.name added a reviewer: royger.
Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2016, 11:39 AM
royger accepted this revision.Feb 11 2016, 11:46 AM
royger edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 11 2016, 11:46 AM
Closed by commit rS295510: xen-netfront: remove pointless assignment in xn_ioctl (authored by royger). · Explain WhyFeb 11 2016, 11:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
xen/
netfront/
2 lines

Diff 13215

View Options

head/sys/dev/xen/netfront/netfront.c

Loading...