Page MenuHomeFreeBSD
Differential D42977

science/paraview: remove useless sbrk use
ClosedPublic
Actions

Authored by brooks on Dec 8 2023, 11:00 PM.
Tags
None
Referenced Files
F138163483: D42977.id131193.diff
Sat, Nov 29, 10:50 AM
Unknown Object (File)
Thu, Nov 27, 1:18 PM
Unknown Object (File)
Thu, Nov 27, 7:52 AM
Unknown Object (File)
Tue, Nov 25, 7:14 AM
Unknown Object (File)
Mon, Nov 17, 11:39 PM
Unknown Object (File)
Tue, Nov 4, 8:39 PM
Unknown Object (File)
Tue, Nov 4, 8:37 PM
Unknown Object (File)
Tue, Nov 4, 8:35 PM
View All Files
Subscribers
None

Details

Reviewers
thierry
Commits
R11:b5f490feb62f: science/paraview: remove useless sbrk use
Summary

There was a single use in a debug statement so just remove it.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 54872
Build 51761: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Dec 8 2023, 11:00 PM
brooks created this revision.
Harbormaster completed remote builds in B54872: Diff 131193.Dec 8 2023, 11:00 PM
brooks added a comment.Dec 8 2023, 11:04 PM

Compiled, but untested on an amd64 world without sbrk.

thierry accepted this revision.Dec 10 2023, 1:43 PM

I have no way to test it on aarch64, but it runs fine on amd64: go!

You could also submit this patch upstream, at https://gitlab.kitware.com/paraview/paraview/-/issues : they are responsive.

This revision is now accepted and ready to land.Dec 10 2023, 1:43 PM
Closed by commit R11:b5f490feb62f: science/paraview: remove useless sbrk use (authored by brooks). · Explain WhyDec 11 2023, 5:42 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: R11:b5f490feb62f: science/paraview: remove useless sbrk use.

Revision Contents
Changeset List

PathSize
science/
paraview/
4 lines
files/
12 lines

Diff 131193

View Options

science/paraview/Makefile

Loading...
View Options

science/paraview/files/patch-VTK_ThirdParty_xdmf2_vtkxdmf2_libsrc_XdmfArray.cxx

Loading...