Page MenuHomeFreeBSD
Differential D698

Add stricter checking of mmap() arguments.
ClosedPublic
Actions

Authored by jhb on Aug 29 2014, 9:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:27 PM
Unknown Object (File)
Fri, Dec 20, 4:18 PM
Unknown Object (File)
Fri, Dec 20, 4:01 PM
Unknown Object (File)
Fri, Dec 20, 10:57 AM
Unknown Object (File)
Mon, Dec 16, 11:05 PM
Unknown Object (File)
Sun, Dec 15, 2:24 PM
Unknown Object (File)
Fri, Nov 29, 10:35 PM
Unknown Object (File)
Sun, Nov 24, 11:54 PM
View All Files
Subscribers
None

Details

Reviewers
kib
Commits
rS271635: Add stricter checking of some mmap() arguments:
Summary

Add stricter checking of some mmap() arguments:

  • Fail with EINVAL if an invalid protection mask is passed to mmap().
  • Fail with EINVAL if an unknown flag is passed to mmap().
  • Fail with EINVAL if both MAP_PRIVATE and MAP_SHARED are passed to mmap().
  • Require one of either MAP_PRIVATE or MAP_SHARED for non-anonymous mappings.
Test Plan
  • Just trying to boot with the original patch forced me to relax the requirement for at least one of MAP_SHARED or MAP_PRIVATE to not be applied for anonymous mappings because libthr uses MAP_ANON without a sharing mode.
  • I wrote a test program to exercise these various new errors as well as several normal use cases. All of the tests succeed on current HEAD, including the ones that pass invalid flags or protection that this change checks for. With the patch, the latter tests now fail.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jhb updated this revision to Diff 1281.Aug 29 2014, 9:56 PM
jhb retitled this revision from to Add stricter checking of mmap() arguments..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb updated this revision to Diff 1459.Sep 10 2014, 8:36 PM

Fixed an issue with prot checking.

jhb edited the test plan for this revision. (Show Details)Sep 10 2014, 8:40 PM
jhb added a reviewer: kib.
jhb updated this revision to Diff 1599.Sep 12 2014, 8:58 PM
jhb edited the test plan for this revision. (Show Details)

Make prot an int.

jhb updated this revision to Diff 1633.Sep 15 2014, 3:13 PM

Check for invalid mmap() flags.

jhb updated this object.Sep 15 2014, 3:15 PM
jhb closed this revision.Sep 15 2014, 5:20 PM
jhb updated this revision to Diff 1635.

Closed by commit rS271635 (authored by @jhb).

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
19 lines
sys/
vm/
7 lines

Diff 1281

View Options

lib/libc/sys/mmap.2

Loading...
View Options

sys/vm/vm_mmap.c

Loading...