Differential D41014

bsd.sites.mk: Avoid bogus dev-warning from makesum
ClosedPublic
Actions

Authored by zirias on Jul 13 2023, 7:33 AM.

Details

Reviewers

tcberner

Group Reviewers

portmgr

Commits

R11:f59f844b65a1: bsd.sites.mk: Avoid bogus dev-warning from makesum

Summary

makesum calls make fetch and passes MASTER_SITES, so the dev warning
about it is triggered by the value USE_GITLAB computes. Avoid this by
disabling the warning in make fetch when NO_CHECKSUM and DISABLE_SIZE
are set.

Test Plan

make makesum in a port with USE_GITLAB does not show a dev warning
adding MASTER_SITES to that port, both make makesum and make fetch show the warning

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 52610
Build 49501: arc lint + arc unit

Event Timeline

zirias created this revision.Jul 13 2023, 7:33 AM

Herald added a reviewer: portmgr. · View Herald TranscriptJul 13 2023, 7:33 AM

Herald added a subscriber: mat. · View Herald Transcript

zirias requested review of this revision.Jul 13 2023, 7:33 AM

Harbormaster completed remote builds in B52610: Diff 124598.Jul 13 2023, 7:33 AM

looks sane enough as a work-around :)

This revision is now accepted and ready to land.Jul 13 2023, 8:38 PM

Closed by commit R11:f59f844b65a1: bsd.sites.mk: Avoid bogus dev-warning from makesum (authored by zirias). · Explain WhyJul 13 2023, 8:54 PM

This revision was automatically updated to reflect the committed changes.

zirias added a commit: R11:f59f844b65a1: bsd.sites.mk: Avoid bogus dev-warning from makesum.

Revision Contents
Changeset List

Path

Size

Mk/

bsd.sites.mk

6 lines

Diff 124598

View Options

bsd.sites.mk: Avoid bogus dev-warning from makesumClosedPublicActions