libpmc: make pmc_pmu_pmcallocate() machine-independent
ClosedPublic
Actions

Authored by mhorne on Jun 24 2023, 7:19 PM.

Details

Reviewers

Commits

rG49e1f23c7715: libpmc: make pmc_pmu_pmcallocate() machine-independent
rG196bb0e152cf: libpmc: make pmc_pmu_pmcallocate() machine-independent
rG45dcc17e2fb8: libpmc: make pmc_pmu_pmcallocate() machine-independent

Summary

Have it call the platform-dependent version. For better layering, move
the reset logic inside the new function. This is mainly to facilitate an
upcoming change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52276
Build 49167: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 24 2023, 7:19 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 24 2023, 7:19 PM

mhorne requested review of this revision.Jun 24 2023, 7:19 PM

Harbormaster completed remote builds in B52276: Diff 123728.Jun 24 2023, 7:20 PM

jkoshy accepted this revision.Jul 7 2023, 6:48 AM

jkoshy added inline comments.

lib/libpmc/libpmc.c
1053	Not related to this change, but I noticed that the `count` parameter that was added in 2018 is both undocumented and unnecessary - `pmc_set(3)`being the recommended way to set or change the counts associated with a PMC.

This revision is now accepted and ready to land.Jul 7 2023, 6:48 AM

mhorne added inline comments.Jul 7 2023, 3:20 PM

lib/libpmc/libpmc.c
1053	It is documented by the `pmc_allocate(3)` man page at least -- apparently I did this in 50f6c13997008. But to your point, I do not know why it was added.