Differential D40202

devel/corrade: fix build on aarch64, missing FreeBSD code
ClosedPublic
Actions

Authored by fuz on May 22 2023, 12:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 24, 3:55 PM

	Unknown Object (File)
	Wed, Mar 18, 1:07 PM

	Unknown Object (File)
	Wed, Mar 18, 4:40 AM

	Unknown Object (File)
	Wed, Mar 18, 3:00 AM

	Unknown Object (File)
	Tue, Mar 17, 2:15 PM

	Unknown Object (File)
	Tue, Mar 17, 8:46 AM

	Unknown Object (File)
	Mon, Mar 16, 6:44 PM

	Unknown Object (File)
	Sun, Mar 15, 4:40 AM

Subscribers

Details

Reviewers

Commits

R11:2313549e74be: devel/corrade: fix build on aarch64, missing FreeBSD code

Summary

devel/corrade: fix build on aarch64, missing FreeBSD code

 - add CPU detection code for armv7, aarch64
   (armv7 is still broken for other reasons)
 - add missing FreeBSD support code for executableLocation()
 - hook up test suite

See also:	https://github.com/mosra/corrade/issues/171

Test Plan

Ran make test and fixed what I could.
Builds fine in Poudriere.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 51593
Build 48484: arc lint + arc unit

Event Timeline

fuz created this revision.May 22 2023, 12:38 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 22 2023, 12:38 PM

fuz requested review of this revision.May 22 2023, 12:38 PM

Harbormaster completed remote builds in B51591: Diff 122209.May 22 2023, 12:38 PM

Update to fixed patch.

Harbormaster completed remote builds in B51593: Diff 122211.May 22 2023, 12:40 PM

Upload fixed fixed patch.

Harbormaster completed remote builds in B51594: Diff 122212.May 22 2023, 12:43 PM

Any news on this one?

Approved,
Please commit it.

This revision is now accepted and ready to land.May 24 2023, 4:27 PM

Closed by commit R11:2313549e74be: devel/corrade: fix build on aarch64, missing FreeBSD code (authored by fuz). · Explain WhyMay 25 2023, 9:44 AM

This revision was automatically updated to reflect the committed changes.

fuz added a commit: R11:2313549e74be: devel/corrade: fix build on aarch64, missing FreeBSD code.

Revision Contents
Changeset List

Path

Size

devel/

corrade/

5 lines

files/

patch-src_Corrade_Cpu.h

38 lines

patch-src_Corrade_Cpu.cpp

34 lines

patch-src_Corrade_Utility_Path.cpp

33 lines

Diff 122211

devel/corrade/Makefile

Loading...

devel/corrade/files/patch-src_Corrade_Cpu.h

Loading...

devel/corrade/files/patch-src_Corrade_Cpu.cpp

Loading...

devel/corrade/files/patch-src_Corrade_Utility_Path.cpp

Loading...