urtwn: add an option to compile the driver without firmware specific code
ClosedPublic
Actions

Authored by avos on Jan 10 2016, 11:19 PM.

Details

Reviewers

kevlo
adrian

Commits

rS295871: urtwn: add an option to compile the driver without firmware specific code

Summary

Add URTWN_WITHOUT_UCODE option (will disable any firmware specific code when set).
Do not exclude the driver from build when MK_SOURCELESS_UCODE is set (URTWN_WITHOUT_UCODE will be enforced unconditionally).
Do not abort initialization when firmware cannot be loaded; behave like the URTWN_WITHOUT_UCODE option was set.
Drop some unused variables from urtwn_softc structure.

Test Plan

Tested with RTL8188EU and RTL8188CUS in HOSTAP and STA modes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 12096.Jan 10 2016, 11:19 PM

avos retitled this revision from to urtwn: add an option to compile the driver without firmware specific code.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 10 2016, 11:19 PM

wait, how's this supposed to work without firmware?

For me, device works fine without firmware (however, firmware commands are not available in that case).

Sorry I don't see the benefits of this change. If you want urtwn(4)
to be similar to the vendor driver as opposed to rewriting from scratch
like damien@ did, I suggest maybe we could implement shim layer in os_dep
directory from the Realtek's vendor source. I've had a patch set but it's
not finished yet.