gvinum: correct assertions
ClosedPublic
Actions

Authored by emaste on Dec 12 2022, 5:11 PM.

Tags

None

Referenced Files

	F160649550: D37677.id.diff
	Fri, Jun 26, 11:54 AM

	Unknown Object (File)
	Thu, Jun 25, 11:22 AM

	Unknown Object (File)
	May 22 2026, 6:37 AM

	Unknown Object (File)
	May 21 2026, 8:46 PM

	Unknown Object (File)
	May 10 2026, 1:40 PM

	Unknown Object (File)
	May 5 2026, 4:22 PM

	Unknown Object (File)
	May 2 2026, 11:17 PM

	Unknown Object (File)
	May 2 2026, 10:37 PM

View All Files

Subscribers

imp

Details

Reviewers

imp

Commits

rG12be1c744e00: gvinum: correct assertions
rG66f3ac8c661d: gvinum: correct assertions
rG87bb53cb5380: gvinum: correct assertions

Summary

Pointer addresses are always >= 0.  Assert that the value is >= 0
instead.

PR:             207855, 207856
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Dec 12 2022, 5:11 PM

emaste created this revision.

Sure, but there's a good chance that long-undetected bugs may render gvinum unusable :)

This revision is now accepted and ready to land.Dec 12 2022, 9:10 PM

Closed by commit rG87bb53cb5380: gvinum: correct assertions (authored by emaste). · Explain WhyMar 21 2023, 2:03 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG87bb53cb5380: gvinum: correct assertions.

emaste added a commit: rG66f3ac8c661d: gvinum: correct assertions.Mar 23 2023, 12:43 PM

emaste added a commit: rG12be1c744e00: gvinum: correct assertions.Mar 23 2023, 12:50 PM

Revision Contents
Changeset List

Path

Size

sys/

geom/

vinum/

geom_vinum_plex.c

2 lines

geom_vinum_raid5.c

4 lines

Diff 119186

View Options

sys/geom/vinum/geom_vinum_plex.c