Page MenuHomeFreeBSD
Differential D4707

- Fix for py-mock
ClosedPublic
Actions

Authored by miwi on Dec 25 2015, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 18, 4:29 PM
Unknown Object (File)
Wed, Mar 18, 12:55 PM
Unknown Object (File)
Mar 14 2026, 3:34 PM
Unknown Object (File)
Mar 12 2026, 12:18 PM
Unknown Object (File)
Mar 11 2026, 4:39 PM
Unknown Object (File)
Feb 27 2026, 12:53 AM
Unknown Object (File)
Jan 30 2026, 5:55 PM
Unknown Object (File)
Jan 29 2026, 2:12 PM
View All Files
Subscribers
None

Details

Reviewers
antoine
koobs
Commits
rP404434: - Add missing dependency

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1831
Build 1838: arc lint + arc unit

Event Timeline

miwi updated this revision to Diff 11678.Dec 25 2015, 3:35 PM
miwi updated this revision to Diff 11679.
miwi retitled this revision from to - Fix for py-mock.
miwi updated this object.
miwi edited the test plan for this revision. (Show Details)
  • Add missing port
miwi updated this revision to Diff 11680.Dec 25 2015, 3:38 PM
miwi added a reviewer: antoine.
miwi added a reviewer: koobs.Dec 25 2015, 3:42 PM
antoine edited edge metadata.Dec 25 2015, 3:43 PM

The new port looks good.

devel/py-mock/Makefile
18

shouldn't it be depending on the version of python (not sure, i don't know how pbr works) ?
something like:

Index: devel/py-mock/Makefile
===================================================================
--- devel/py-mock/Makefile      (revision 404428)
+++ devel/py-mock/Makefile      (working copy)
@@ -23,4 +23,10 @@
 
 TESTS_RUN_DEPENDS=     ${PYTHON_PKGNAMEPREFIX}tox>0:${PORTSDIR}/devel/py-tox
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if ${PYTHON_REL} < 3300
+RUN_DEPENDS+=  ${PYTHON_PKGNAMEPREFIX}funcsigs>=0:${PORTSDIR}/devel/py-funcsigs
+.endif
+
+.include <bsd.port.post.mk>
koobs requested changes to this revision.Dec 25 2015, 3:44 PM
koobs edited edge metadata.
koobs added inline comments.
devel/py-funcsigs/Makefile
18 ↗(On Diff #11680)
do-test:
    @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test

Should just work here given authors have nicely set test_suite in setup.py

devel/py-mock/Makefile
16

Even though python.mk implicitly adds setuptools to BUILD/RUN depends, this may not be the case forever.

Upstream explicitly states they require setuptools at setup (BUILD) time, so add that here

20–21

Remove TESTS option, conditionals, and convert test bits to use the new test framework

This revision now requires changes to proceed.Dec 25 2015, 3:44 PM
miwi updated this revision to Diff 11682.Dec 25 2015, 3:54 PM
miwi edited edge metadata.
miwi updated this revision to Diff 11683.Dec 25 2015, 4:07 PM
miwi edited edge metadata.
  • Add explicit setuptools
  • Add py-six dependency
miwi updated this revision to Diff 11684.Dec 25 2015, 4:13 PM

Remove duplicate funcsigs

koobs requested changes to this revision.Dec 25 2015, 4:22 PM
koobs edited edge metadata.
koobs added inline comments.
devel/py-mock/Makefile
24

Leftover from TESTS option.

Should be TEST_DEPENDS, and moved up to *_DEPENDS section

This revision now requires changes to proceed.Dec 25 2015, 4:22 PM
miwi updated this revision to Diff 11685.Dec 25 2015, 4:25 PM
miwi edited edge metadata.

remove test left overs, etc .

koobs accepted this revision.Dec 25 2015, 4:26 PM
koobs edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2015, 4:26 PM
Closed by commit rP404434: - Add missing dependency (authored by miwi). · Explain WhyDec 25 2015, 4:32 PM
This revision was automatically updated to reflect the committed changes.
miwi mentioned this in rP404434: - Add missing dependency.

Revision Contents
Changeset List

PathSize
devel/
py-mock/
4 lines

Diff 11678

View Options

devel/py-mock/Makefile

Loading...