- Update to 2.6.1.0
ClosedPublic
Actions

Authored by miwi on Dec 19 2015, 2:57 PM.

Details

Reviewers

bapt
mat

Commits

rP404329: - Update to 2.6.0.0

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1783
Build 1789: arc lint + arc unit

miwi retitled this revision from to - Update to 2.6.1.0.

miwi updated this object.

miwi edited the test plan for this revision. (Show Details)

miwi added reviewers: mat, bapt.

games/asc/Makefile
16	unneeded change.
27–28	no need to change the order here.
29	Unneeded change.
29	no real need to move that line either.
49–50	use ${DATADIR} here
65	Why not use `${CP}` here ?
74–75	no need to change the order of the lines.

games/asc/Makefile
49–50	Do you mind to explain this to me. We used always %%DATADIR%% for PLIST_FILES, https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html 6.14.3. Best Practices, Suggest also to use %%FOO%%.

games/asc/Makefile
49–50	The only reason there are %%FOO%% thingies in the pkg-plist files is because we need a way to represent the content of ${FOO} in there. When you are in the Makefile, you already have access to ${FOO} there is no need to not use it directly. I'll change the porter's handbook bit about java best practices, I don't use java so I never went over that section.