Page MenuHomeFreeBSD
Differential D37982

Add new textproc/docproj-fonts-cjk to docproj meta port
ClosedPublic
Actions

Authored by carlavilla on Jan 8 2023, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 8:47 AM
Unknown Object (File)
Tue, Nov 26, 8:47 AM
Unknown Object (File)
Tue, Nov 26, 6:37 AM
Unknown Object (File)
Wed, Nov 20, 8:56 AM
Unknown Object (File)
Mon, Nov 18, 5:29 AM
Unknown Object (File)
Mon, Nov 18, 12:32 AM
Unknown Object (File)
Sun, Nov 17, 10:36 AM
Unknown Object (File)
Sat, Nov 16, 11:17 PM
View All Files
Subscribers
dbaio

Details

Reviewers
dbaio
Group Reviewers
doceng
Commits
R11:44dd7f0d788f: textproc/docproj: Add option to install CJK fonts to build PDF files
Summary

sunpoet@ has created a new port[|] to allow us to correctly generate pdfs in Chinese, Japanese and Korean.

With this new port the size of the metaport is barely increased, which is the problem we had the other time.

[1] https://cgit.freebsd.org/ports/commit/?id=5ba192122fdabb02bdc6ad3afac66631c2c586be

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

carlavilla requested review of this revision.Jan 8 2023, 7:02 PM
carlavilla created this revision.
dbaio requested changes to this revision.Jan 8 2023, 11:07 PM
dbaio added a subscriber: dbaio.
textproc/docproj/Makefile
15

What about naming it just FONTS-CJK?

16

Let's not enable it by default; we can revisit it when it's all working.
For the FreeBSD CI, I can enable this option.

18

I think it's better Required CJK fonts to build PDF files

This revision now requires changes to proceed.Jan 8 2023, 11:07 PM
carlavilla updated this revision to Diff 115329.Jan 19 2023, 7:06 PM
dbaio added inline comments.Jan 19 2023, 7:12 PM
textproc/docproj/Makefile
16

Invert this, move FONTS-CJK to OPTIONS_DEFINE.

carlavilla updated this revision to Diff 115330.Jan 19 2023, 7:14 PM
carlavilla marked 4 inline comments as done.
dbaio added inline comments.Jan 19 2023, 7:24 PM
textproc/docproj/Makefile
24

It's FONTS-CJK_RUN_DEPENDS here.
While changing it, let this and FONTS-CJK_DESC below EPUB_* variables to let them in alphabetical order.

carlavilla updated this revision to Diff 115331.Jan 19 2023, 7:27 PM
carlavilla marked an inline comment as done.
dbaio accepted this revision.Jan 19 2023, 7:33 PM

Looks good to me.

Minor, I would also move FONTS-CJK_DESC= to below EPUB_DESC= before committing.

This revision is now accepted and ready to land.Jan 19 2023, 7:33 PM
carlavilla added a comment.Jan 19 2023, 7:34 PM

Thanks, I forgot about this order too

Closed by commit R11:44dd7f0d788f: textproc/docproj: Add option to install CJK fonts to build PDF files (authored by carlavilla, committed by dbaio). · Explain WhyJan 20 2023, 7:45 PM
This revision was automatically updated to reflect the committed changes.
dbaio added a commit: R11:44dd7f0d788f: textproc/docproj: Add option to install CJK fonts to build PDF files.

Revision Contents
Changeset List

PathSize
textproc/
docproj/
6 lines

Diff 115331

View Options

textproc/docproj/Makefile

Loading...