cal: don't print terminal control characters unless stdout is a TTY
ClosedPublic
Actions

Authored by asomers on Jan 13 2023, 8:22 PM.

Details

Reviewers

imp
grog

Commits

rG0811d18fea91: cal: don't print terminal control characters unless stdout is a TTY
rG92e978439f0c: cal: don't print terminal control characters unless stdout is a TTY

Summary

A similar change was made in svn r223931, but it was incomplete, working
only when the utility was invoked as "ncal". Fix the same issue when
invoking as "cal".

PR: 268936
Reported by: Ray Bellis <ray@bellis.me.uk>
MFC after: 2 weeks
Sponsored by: Axcient

Test Plan

manually tested with "cal | xxd"

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49098
Build 45987: arc lint + arc unit

Event Timeline

asomers requested review of this revision.Jan 13 2023, 8:22 PM

asomers created this revision.

Harbormaster completed remote builds in B49098: Diff 115057.Jan 13 2023, 8:22 PM

Yea, we really should only be gaudying up the output when talking to a tty....

This revision is now accepted and ready to land.Jan 13 2023, 9:18 PM

Closed by commit rG92e978439f0c: cal: don't print terminal control characters unless stdout is a TTY (authored by asomers). · Explain WhyJan 13 2023, 9:30 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG92e978439f0c: cal: don't print terminal control characters unless stdout is a TTY.

asomers added a commit: rG0811d18fea91: cal: don't print terminal control characters unless stdout is a TTY.Jan 27 2023, 7:32 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

ncal/

ncal.c

3 lines

Diff 115057

View Options

cal: don't print terminal control characters unless stdout is a TTYClosedPublicActions