Page MenuHomeFreeBSD
Differential D37500

Add check to detect colon in .CURDIR
ClosedPublic
Actions

Authored by pizzamig on Nov 24 2022, 11:06 PM.
Tags
None
Referenced Files
F110097694: D37500.diff
Thu, Feb 13, 2:20 PM
Unknown Object (File)
Wed, Feb 5, 11:02 PM
Unknown Object (File)
Sat, Jan 18, 11:54 AM
Unknown Object (File)
Fri, Jan 17, 4:08 PM
Unknown Object (File)
Jan 13 2025, 11:52 AM
Unknown Object (File)
Nov 30 2024, 6:56 PM
Unknown Object (File)
Nov 29 2024, 3:19 AM
Unknown Object (File)
Nov 24 2024, 11:54 PM
View All 69 Files
Subscribers
mat
tcberner

Details

Reviewers
tcberner
Group Reviewers
portmgr
Commits
R11:93a86257b76d: component: Mk framework
Summary

colon in .CURDIR is not supported

this patch detects the colon and shows a proper error message

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 48501
Build 45387: arc lint + arc unit

Event Timeline

pizzamig created this revision.Nov 24 2022, 11:06 PM
pizzamig held this revision as a draft.
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptNov 24 2022, 11:06 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B48501: Diff 113506.Nov 24 2022, 11:06 PM
pizzamig published this revision for review.Nov 24 2022, 11:10 PM
pizzamig removed 1 blocking reviewer(s): portmgr.Nov 29 2022, 9:00 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptNov 29 2022, 9:00 PM
tcberner added a subscriber: tcberner.Nov 30 2022, 7:13 AM
tcberner added inline comments.
Mk/bsd.port.mk
1058

'this is' instead of 'that are' ?

Mk/bsd.port.subdir.mk
56

^see above

pizzamig updated this revision to Diff 113698.Nov 30 2022, 9:05 PM
  • Fix English in the error message
Harbormaster completed remote builds in B48577: Diff 113698.Nov 30 2022, 9:05 PM
pizzamig marked 2 inline comments as done.Nov 30 2022, 9:06 PM
tcberner accepted this revision.Dec 1 2022, 5:19 AM

lgtm (although I'm not quite sure how often that is really an issue :D -- I mean, who will create a directory with a ':' in it by choice?)

This revision is now accepted and ready to land.Dec 1 2022, 5:19 AM
Closed by commit R11:93a86257b76d: component: Mk framework (authored by pizzamig). · Explain WhyJan 11 2023, 10:42 PM
This revision was automatically updated to reflect the committed changes.
pizzamig added a commit: R11:93a86257b76d: component: Mk framework.

Revision Contents
Changeset List

PathSize
Mk/
5 lines
5 lines

Diff 113506

View Options

Mk/bsd.port.mk

Loading...
View Options

Mk/bsd.port.subdir.mk

Loading...