databases/mongodb60: mark broken on FreeBSD 12.
ClosedPublic
Actions

Authored by ronald_klop.ws on Nov 1 2022, 3:14 PM.

Details

Reviewers

rene
pkubaj

Commits

R11:55836daf2c06: databases/mongodb60: mark ignore on FreeBSD 12.3.
R11:34381447a02d: databases/mongodb60: mark ignore on FreeBSD 12.3.

Summary

Llvm in FreeBSD 12.3 gives several compile errors.
One example:
src/mongo/s/sharding_initialization.cpp:171:49: error: no viable constructor or deduction guide for deduction of template arguments of 'weak_ptr'

connPoolOptions.controllerFactory = [srwp = std::weak_ptr(srsp)] {

http://beefy6.nyi.freebsd.org/data/123amd64-default/0116f5c59197/logs/errors/mongodb60-6.0.2.log

PR: 266587

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 48116
Build 45003: arc lint + arc unit

Event Timeline

ronald_klop.ws created this revision.Nov 1 2022, 3:14 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 1 2022, 3:14 PM

ronald_klop.ws requested review of this revision.Nov 1 2022, 3:14 PM

Harbormaster completed remote builds in B48111: Diff 112462.Nov 1 2022, 3:14 PM

I tried compiling with llvm12, but got the same error.
So lets try again when 12.4 is released. When this is in I want to merge the fixes to quarterly.

In D37230#845331, @ronald_klop.ws wrote:

I tried compiling with llvm12, but got the same error.
So lets try again when 12.4 is released. When this is in I want to merge the fixes to quarterly.

Do note there is a 3-4 month overlap between 12.3 and 12.4.

databases/mongodb60/Makefile
17	FreeBSD 12.4 will have a newer libc++ so the port will probably build there, so an alternative would be to add a BROKEN for 12.3 only (which needs manual code, see e.g. commit df6f60b28be35b500fec4d8573159e22a88b489c in www/chromium)

ronald_klop.ws added inline comments.Nov 1 2022, 9:45 PM

databases/mongodb60/Makefile
17	Thanks. I’m going to try your OSREL suggestion.

Use OSREL=12.3 so it will start compiling again when 12.4 is released. As suggested by rene.

Harbormaster completed remote builds in B48116: Diff 112485.Nov 2 2022, 9:43 AM

ronald_klop.ws marked an inline comment as done.Nov 2 2022, 9:46 AM

rene accepted this revision.Nov 3 2022, 9:08 AM

This revision is now accepted and ready to land.Nov 3 2022, 9:08 AM

Perhaps IGNORE would be better, as it indicates that the port will not be fixed anymore on 12.3. See https://docs.freebsd.org/en/books/porters-handbook/porting-dads/#dads-noinstall-variables The main difference is that the port won't be built anymore in a TRY_BROKEN run if it is marked as IGNORE.

Closed by commit R11:34381447a02d: databases/mongodb60: mark ignore on FreeBSD 12.3. (authored by ronald_klop.ws). · Explain WhyNov 3 2022, 10:35 AM

This revision was automatically updated to reflect the committed changes.

ronald_klop.ws added a commit: R11:34381447a02d: databases/mongodb60: mark ignore on FreeBSD 12.3..

ronald_klop.ws added a commit: R11:55836daf2c06: databases/mongodb60: mark ignore on FreeBSD 12.3..Nov 3 2022, 9:47 PM