Page MenuHomeFreeBSD
Differential D36836

multimedia/makemkv: Use new linux-c7 -devel pkgs
ClosedPublic
Actions

Authored by zirias on Sep 30 2022, 7:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 4:14 PM
Unknown Object (File)
Mon, May 20, 4:13 PM
Unknown Object (File)
Mon, May 20, 4:13 PM
Unknown Object (File)
Mon, May 20, 4:13 PM
Unknown Object (File)
Fri, May 17, 10:26 PM
Unknown Object (File)
Mon, May 13, 3:18 PM
Unknown Object (File)
Mon, May 13, 2:01 AM
Unknown Object (File)
Sun, May 12, 10:25 PM
View All 57 Files
Subscribers
mat

Details

Reviewers
tcberner
Commits
R11:b7be88867a05: multimedia/makemkv: Use new linux-c7 -devel pkgs
Summary

This avoids fetching upstream distfiles just for OpenSSL headers. Bump
port revision because different headers are used.

Also drop perl5 dependency (not needed any more) and avoid little-known
AT&T style replacements in Makefile.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zirias created this revision.Sep 30 2022, 7:12 AM
Herald added a subscriber: mat. · View Herald TranscriptSep 30 2022, 7:12 AM
zirias requested review of this revision.Sep 30 2022, 7:12 AM
Harbormaster completed remote builds in B47652: Diff 111261.Sep 30 2022, 7:12 AM
tcberner added inline comments.Sep 30 2022, 7:45 AM
multimedia/makemkv/Makefile
35–38

^ I would add a line break after expat, so that the "build&run" depends are clearly separted:

USE_LINUX=base expat \
                    devools:build [...]
zirias updated this revision to Diff 111266.Sep 30 2022, 10:26 AM

Ok then, would look like this...

Harbormaster completed remote builds in B47654: Diff 111266.Sep 30 2022, 10:26 AM
tcberner accepted this revision.Sep 30 2022, 4:18 PM

lgtm

This revision is now accepted and ready to land.Sep 30 2022, 4:18 PM
Closed by commit R11:b7be88867a05: multimedia/makemkv: Use new linux-c7 -devel pkgs (authored by zirias). · Explain WhySep 30 2022, 4:20 PM
This revision was automatically updated to reflect the committed changes.
zirias added a commit: R11:b7be88867a05: multimedia/makemkv: Use new linux-c7 -devel pkgs.

Revision Contents
Changeset List

PathSize
multimedia/
makemkv/
45 lines

Diff 111280

View Options

multimedia/makemkv/Makefile

Loading...