elfcopy: include extension but replace . when converting from binary
ClosedPublic
Actions

Authored by emaste on Dec 9 2015, 5:26 PM.

Details

Reviewers

Commits

rS292116: elfcopy: include extension but replace . when converting from binary

Summary

The change in rS291958 was not consistent with GNU objcopy. The start/end/size symbols created for ELF objects converted from binary need to include the full filename including the extension, but with periods replaced with underscores.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

readelf -s shows the following for a fuzz.txt file converted to ELF:

Symbol table '.symtab' contains 5 entries:
   Num:    Value          Size Type    Bind   Vis      Ndx Name
     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
     1: 0000000000000000     0 SECTION LOCAL  DEFAULT    1 
     2: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT    1 _binary_fuzz_txt_start
     3: 00000000000011d0     0 NOTYPE  GLOBAL DEFAULT    1 _binary_fuzz_txt_end
     4: 00000000000011d0     0 NOTYPE  GLOBAL DEFAULT  ABS _binary_fuzz_txt_size

Check for failure from strdup

imp accepted this revision.Dec 9 2015, 6:37 PM

imp edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2015, 6:37 PM

Closed by commit rS292116: elfcopy: include extension but replace . when converting from binary (authored by emaste). · Explain WhyDec 11 2015, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Committed upstream in r3270

Revision Contents
Changeset List

Path

Size

elfcopy/

binary.c

20 lines

Diff 10988

View Options

elfcopy: include extension but replace . when converting from binaryClosedPublicActions