Differential D36031

comms/opencbm: Update to 0.4.99.104
ClosedPublic
Actions

Authored by zirias on Aug 3 2022, 9:28 AM.

Tags

None

Referenced Files

	F170176980: D36031.id108845.diff
	Thu, Sep 3, 6:07 PM

	F170129619: D36031.id108846.diff
	Thu, Sep 3, 2:44 PM

	F170116851: D36031.diff
	Thu, Sep 3, 1:42 PM

	F170062459: D36031.id.diff
	Thu, Sep 3, 9:59 AM

	Unknown Object (File)
	Wed, Sep 2, 5:37 PM

	Unknown Object (File)
	Tue, Sep 1, 2:10 PM

	Unknown Object (File)
	Tue, Sep 1, 12:56 PM

	Unknown Object (File)
	Tue, Sep 1, 12:41 PM

Subscribers

Details

Reviewers

Commits

R11:0a90d3d9f966: comms/opencbm: Update to 0.4.99.104

Summary

Remove MAJE_JOBS_UNSAFE, fixed upstream with additional make dependencies.
Remove local copy of opencbm(4), manpage was adopted upstream.
Also affects opencbm-kmod and opencbm-plugin-xa1541.

Changelog: https://opencbm.trikaliotis.net/opencbm-6.html

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 46735
Build 43624: arc lint + arc unit

Event Timeline

zirias created this revision.Aug 3 2022, 9:28 AM

Herald added a subscriber: mat. · View Herald TranscriptAug 3 2022, 9:28 AM

zirias requested review of this revision.Aug 3 2022, 9:28 AM

Harbormaster completed remote builds in B46735: Diff 108845.Aug 3 2022, 9:29 AM

tcberner added inline comments.Aug 3 2022, 9:47 AM

comms/opencbm-plugin-xa1541/Makefile
21	^ this looks static -- is there a reason it is not a patch file?
comms/opencbm/Makefile.inc
10	^ might be a bit more readable if you break the line for every value you set

zirias added inline comments.Aug 3 2022, 9:55 AM

comms/opencbm-plugin-xa1541/Makefile
21	It's already fixed upstream, so I thought for something temporary, it might be better not to add an extra file?

zirias marked an inline comment as done.Aug 3 2022, 9:59 AM

Extra newline as suggested.

Harbormaster completed remote builds in B46736: Diff 108846.Aug 3 2022, 10:01 AM

tcberner added inline comments.Aug 3 2022, 10:10 AM

comms/opencbm-plugin-xa1541/Makefile
21	if it's already fixed upstream, you could try to pull in their (git)-patch. -- if that does not work I would at least add a comment saying that this is a temporary thing.

Replace sed with upstream patch.

Harbormaster completed remote builds in B46737: Diff 108849.Aug 3 2022, 10:20 AM

zirias marked 2 inline comments as done.Aug 3 2022, 10:20 AM

stlgtm

This revision is now accepted and ready to land.Aug 3 2022, 7:12 PM

Closed by commit R11:0a90d3d9f966: comms/opencbm: Update to 0.4.99.104 (authored by zirias). · Explain WhyAug 3 2022, 7:21 PM

This revision was automatically updated to reflect the committed changes.

zirias added a commit: R11:0a90d3d9f966: comms/opencbm: Update to 0.4.99.104.

Revision Contents
Changeset List

Path

Size

comms/

opencbm-kmod/

3 lines

files/

	opencbm-kmod/	files/
	opencbm/	files/

	patch-compat-freebsd-14
	patch-opencbm_sys_freebsd_opencbm.c

13 lines

opencbm-plugin-xa1541/

11 lines

2 lines

opencbm/

7 lines

16 lines

12 lines

files/

patch-opencbm_sys_freebsd_opencbm.c

7 lines

Diff 108845

comms/opencbm-kmod/Makefile

Loading...

comms/opencbm-kmod/files/opencbm.4

Loading...

comms/opencbm-kmod/files/patch-compat-freebsd-14

Loading...

comms/opencbm-plugin-xa1541/Makefile

Loading...

comms/opencbm-plugin-xa1541/pkg-plist

Loading...

comms/opencbm/Makefile

Loading...

comms/opencbm/Makefile.inc

Loading...

comms/opencbm/distinfo

Loading...

comms/opencbm/files/patch-opencbm_sys_freebsd_opencbm.c

Loading...

comms/opencbm/pkg-plist

Loading...