Page MenuHomeFreeBSD
Differential D35997

[NEW PORT] comms/cyclonedds: Eclipse Cyclone DDS middleware
ClosedPublic
Actions

Authored by flo_purplekraken.com on Jul 30 2022, 6:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 10:00 AM
Unknown Object (File)
Mon, Oct 28, 5:03 PM
Unknown Object (File)
Wed, Oct 23, 9:51 AM
Unknown Object (File)
Mon, Oct 21, 4:32 PM
Unknown Object (File)
Mon, Oct 21, 4:32 PM
Unknown Object (File)
Mon, Oct 21, 4:32 PM
Unknown Object (File)
Mon, Oct 21, 4:32 PM
Unknown Object (File)
Fri, Oct 18, 8:15 PM
View All Files
Subscribers
None

Details

Reviewers
arrowd
Group Reviewers
Contributor Reviewers (ports)
Commits
R11:f71e44bc779b: comms/cyclonedds: + Eclipse Cyclone DDS middleware
Summary
Eclipse Cyclone DDS is a very performant and robust open-source implementation
of the OMG DDS specification. Cyclone DDS is developed completely in the open
as an Eclipse IoT project (see eclipse-cyclone-dds) with a growing list of
adopters (if you're one of them, please add your logo). It is a tier-1
middleware for the Robot Operating System ROS 2.

WWW: https://cyclonedds.io/

Add comms/cyclonedds port.

Test Plan
  • portlint: OK
  • portclippy: OK
  • testport: amd64, 13.1-RELEASE tested

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

flo_purplekraken.com requested review of this revision.Jul 30 2022, 6:22 AM
flo_purplekraken.com created this revision.
flo_purplekraken.com added a reviewer: Contributor Reviewers (ports).
flo_purplekraken.com retitled this revision from [NEW PORT] to [NEW PORT] comms/cyclonedds: Eclipse Cyclone DDS middleware.Jul 30 2022, 6:25 AM
flo_purplekraken.com updated this revision to Diff 108738.Jul 30 2022, 4:02 PM
  • Replace PORTVERSION with DISTVERSION.
  • Remove DOCS_DESC.
flo_purplekraken.com added a reviewer: arrowd.Jul 31 2022, 2:40 PM
arrowd requested changes to this revision.Jul 31 2022, 5:26 PM
arrowd added inline comments.
comms/cyclonedds/Makefile
2

How about CycloneDDS here? This will enable %%DOCSDIR%% substitution in the plist.

This revision now requires changes to proceed.Jul 31 2022, 5:26 PM
arrowd added a comment.Jul 31 2022, 5:27 PM

Also, add the port to comms/Makefile.

flo_purplekraken.com added inline comments.Jul 31 2022, 5:39 PM
comms/cyclonedds/Makefile
2

On the other hand it will break the fetch, because the distfiles use the lower-case name:

=> eclipse-cyclonedds-CycloneDDS-0.9.1_GH0.tar.gz is not in /usr/ports/comms/cyclonedds/distinfo.
=> Either /usr/ports/comms/cyclonedds/distinfo is out of date, or
=> eclipse-cyclonedds-CycloneDDS-0.9.1_GH0.tar.gz is spelled incorrectly.

What is the upside of the %%DOCSDIR%% substitution, is it worth it?

flo_purplekraken.com updated this revision to Diff 108753.Jul 31 2022, 5:41 PM

Added cyclonedds to comms/Makefile.

arrowd added inline comments.Jul 31 2022, 5:45 PM
comms/cyclonedds/Makefile
2

Add GH_PROJECT=cyclonedds, then.

What is the upside of the %%DOCSDIR%% substitution, is it worth it?

The Ports Framework will recognize these paths as docs and prepend %%PORTDOCS%% too.

flo_purplekraken.com updated this revision to Diff 108756.Jul 31 2022, 7:39 PM
  • Rename the port to CycloneDDS
  • Fix option variables
flo_purplekraken.com marked 2 inline comments as done.Jul 31 2022, 7:40 PM
arrowd requested changes to this revision.Jul 31 2022, 8:46 PM

Building with TESTS enabled results in:

CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find CUnit (missing: CUNIT_LIBRARY CUNIT_INCLUDE_DIR)

You need TEST_DEPENDS=....

comms/cyclonedds/Makefile
24

The canonical name for this option is TEST.

This revision now requires changes to proceed.Jul 31 2022, 8:46 PM
flo_purplekraken.com updated this revision to Diff 108781.Aug 1 2022, 4:34 PM
flo_purplekraken.com set the repository for this revision to R11 FreeBSD ports repository.

Fixed the test dependencies; before the failures they were hidden by the invalid use of option flags.

arrowd accepted this revision as: arrowd.Aug 1 2022, 5:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2022, 5:42 PM
Closed by commit R11:f71e44bc779b: comms/cyclonedds: + Eclipse Cyclone DDS middleware (authored by flo_purplekraken.com, committed by arrowd). · Explain Why
This revision was automatically updated to reflect the committed changes.
arrowd added a commit: R11:f71e44bc779b: comms/cyclonedds: + Eclipse Cyclone DDS middleware.

Revision Contents
Changeset List

PathSize
comms/
1 line
cyclonedds/
34 lines
3 lines
7 lines
225 lines

Diff 108781

View Options

comms/Makefile

Loading...
View Options

comms/cyclonedds/Makefile

Loading...
View Options

comms/cyclonedds/distinfo

Loading...
View Options

comms/cyclonedds/pkg-descr

Loading...
View Options

comms/cyclonedds/pkg-plist

Loading...