pbio: Return BUS_PROBE_DEFAULT from probe instead of 0.
ClosedPublic
Actions

Authored by jhb on Apr 27 2022, 3:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 19, 8:09 PM

	Unknown Object (File)
	Wed, Aug 19, 3:19 PM

	Unknown Object (File)
	Wed, Aug 19, 1:02 PM

	Unknown Object (File)
	Tue, Aug 18, 8:17 PM

	Unknown Object (File)
	Tue, Aug 18, 4:27 PM

	Unknown Object (File)
	Tue, Aug 18, 4:27 PM

	Unknown Object (File)
	Mon, Aug 17, 12:33 PM

	Unknown Object (File)
	Sun, Aug 16, 9:43 PM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rGbde0080b3dec: pbio: Return BUS_PROBE_DEFAULT from probe instead of 0.
rG4942e8df472b: pbio: Return BUS_PROBE_DEFAULT from probe instead of 0.

Summary

0 should only be returned from probe in legacy drivers that need to
preserve softc state between probe and attach.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 27 2022, 3:40 PM

jhb created this revision.

jhb added a parent revision: D35079: pbio: Axe bus_space tag/handle using bus_read/write_1 instead..

jhb added a child revision: D35081: pbio: Add locking and remove D_NEEDGIANT..

Harbormaster completed remote builds in B45395: Diff 105469.Apr 27 2022, 3:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 5 2022, 11:44 PM

Closed by commit rG4942e8df472b: pbio: Return BUS_PROBE_DEFAULT from probe instead of 0. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4942e8df472b: pbio: Return BUS_PROBE_DEFAULT from probe instead of 0..

jhb added a commit: rGbde0080b3dec: pbio: Return BUS_PROBE_DEFAULT from probe instead of 0..May 20 2022, 12:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pbio/

pbio.c

2 lines

Diff 105728

View Options

pbio: Return BUS_PROBE_DEFAULT from probe instead of 0.ClosedPublicActions