Page MenuHomeFreeBSD
Differential D35090

fusefs: use fsname mount option if set
ClosedPublic
Actions

Authored by ali.abdallah_suse.com on Apr 28 2022, 7:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 19, 12:15 PM
Unknown Object (File)
Tue, Nov 18, 4:17 AM
Unknown Object (File)
Sun, Nov 16, 1:01 PM
Unknown Object (File)
Sun, Nov 16, 5:01 AM
Unknown Object (File)
Thu, Nov 13, 8:31 PM
Unknown Object (File)
Thu, Nov 13, 5:41 PM
Unknown Object (File)
Sun, Nov 9, 5:43 AM
Unknown Object (File)
Sat, Nov 8, 2:38 PM
View All Files
Subscribers
asomers
imp
Restricted Owners Package

Details

Reviewers
asomers
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rG2737e6bca78c: fusefs: use the fsname mount option if set
rG2f6362484c0e: fusefs: use the fsname mount option if set
Summary

Use fsname if it set as f_mntfromname, this improves the output of df -hT, which will become

/dev/da0s1 fusefs 58G 814M 57G 1% /media/extfat
instead of
/dev/fuse fusefs 58G 814M 57G 1% /media/extfat

This requires no changes to existing fuse-libs based filesystem or other fuse fs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ali.abdallah_suse.com created this revision.Apr 28 2022, 7:53 AM
Herald added subscribers: asomers, imp. · View Herald TranscriptApr 28 2022, 7:53 AM
ali.abdallah_suse.com requested review of this revision.Apr 28 2022, 7:53 AM
ali.abdallah_suse.com mentioned this in D35088: Add fuse mount information to 'from'.
ali.abdallah_suse.com updated this revision to Diff 105521.Apr 28 2022, 8:22 AM

Use vfs_getopt instead of vfs_getopts

asomers added a comment.Apr 28 2022, 12:33 PM

Does anything already set fsname? libfuse, perhaps?

ali.abdallah_suse.com added a comment.Apr 28 2022, 12:38 PM
In D35090#795234, @asomers wrote:

Does anything already set fsname? libfuse, perhaps?

Yes, libfuse calls mount_fusefs on FreeBSD with fsname set, expect that it is currently ignored by mount_fusefs.

Enabling it in mount_fusefs, and optionally set it as f_mntfromname if it exists in the fuse kernel driver works with no issue for me.

ali.abdallah_suse.com updated this revision to Diff 105537.Apr 28 2022, 7:23 PM

Use specific m_flag for fsname= mount option field.

asomers accepted this revision.Apr 29 2022, 4:53 PM

LGTM, and it works out of the box with at least one file system in ports.

This revision is now accepted and ready to land.Apr 29 2022, 4:53 PM
Closed by commit rG2f6362484c0e: fusefs: use the fsname mount option if set (authored by asomers). · Explain WhyApr 29 2022, 5:13 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG2f6362484c0e: fusefs: use the fsname mount option if set.
asomers added a commit: rG2737e6bca78c: fusefs: use the fsname mount option if set.May 23 2022, 7:11 PM

Revision Contents
Changeset List

PathSize
sbin/
mount_fusefs/
6 lines
sys/
fs/
fuse/
7 lines
tests/
sys/
fs/
fusefs/
2 lines
6 lines
20 lines
2 lines
2 lines

Diff 105551

View Options

sbin/mount_fusefs/mount_fusefs.c

Loading...
View Options

sys/fs/fuse/fuse_vfsops.c

Loading...
View Options

tests/sys/fs/fusefs/mockfs.hh

Loading...
View Options

tests/sys/fs/fusefs/mockfs.cc

Loading...
View Options

tests/sys/fs/fusefs/mount.cc

Loading...
View Options

tests/sys/fs/fusefs/utils.hh

Loading...
View Options

tests/sys/fs/fusefs/utils.cc

Loading...