Differential D35090

fusefs: use fsname mount option if set
ClosedPublic
Actions

Authored by ali.abdallah_suse.com on Apr 28 2022, 7:53 AM.

Details

Reviewers

asomers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rG2737e6bca78c: fusefs: use the fsname mount option if set
rG2f6362484c0e: fusefs: use the fsname mount option if set

Summary

Use fsname if it set as f_mntfromname, this improves the output of df -hT, which will become

/dev/da0s1 fusefs 58G 814M 57G 1% /media/extfat
instead of
/dev/fuse fusefs 58G 814M 57G 1% /media/extfat

This requires no changes to existing fuse-libs based filesystem or other fuse fs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ali.abdallah_suse.com created this revision.Apr 28 2022, 7:53 AM

Herald added subscribers: asomers, imp. · View Herald TranscriptApr 28 2022, 7:53 AM

ali.abdallah_suse.com requested review of this revision.Apr 28 2022, 7:53 AM

ali.abdallah_suse.com mentioned this in D35088: Add fuse mount information to 'from'.

Use vfs_getopt instead of vfs_getopts

Does anything already set fsname? libfuse, perhaps?

In D35090#795234, @asomers wrote:

Does anything already set fsname? libfuse, perhaps?

Yes, libfuse calls mount_fusefs on FreeBSD with fsname set, expect that it is currently ignored by mount_fusefs.

Enabling it in mount_fusefs, and optionally set it as f_mntfromname if it exists in the fuse kernel driver works with no issue for me.

Use specific m_flag for fsname= mount option field.

LGTM, and it works out of the box with at least one file system in ports.

This revision is now accepted and ready to land.Apr 29 2022, 4:53 PM

Closed by commit rG2f6362484c0e: fusefs: use the fsname mount option if set (authored by asomers). · Explain WhyApr 29 2022, 5:13 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG2f6362484c0e: fusefs: use the fsname mount option if set.

asomers added a commit: rG2737e6bca78c: fusefs: use the fsname mount option if set.May 23 2022, 7:11 PM

Revision Contents
Changeset List

Path

Size

sbin/

mount_fusefs/

mount_fusefs.c

4 lines

sys/

fs/

fuse/

fuse_vfsops.c

5 lines

Diff 105520

View Options

sbin/mount_fusefs/mount_fusefs.c