pbio: Store softc in si_drv1 for character devices.
ClosedPublic
Actions

Authored by jhb on Apr 27 2022, 3:40 PM.

Details

Reviewers

Commits

rGf02bf967fcd3: pbio: Store softc in si_drv1 for character devices.
rG0db65574bbb9: pbio: Store softc in si_drv1 for character devices.

Summary

The port number is still stored in the unit (si_drv0) but is the
entire unit value now.

While here, removed checks for NULL softc since those can never happen
from cdevsw routines. This also resulted in the close method becoming
a no-op, so it has been removed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45393
Build 42281: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 27 2022, 3:40 PM

jhb created this revision.

Harbormaster completed remote builds in B45393: Diff 105467.Apr 27 2022, 3:40 PM

jhb added a child revision: D35079: pbio: Axe bus_space tag/handle using bus_read/write_1 instead..Apr 27 2022, 3:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 5 2022, 11:43 PM

Closed by commit rG0db65574bbb9: pbio: Store softc in si_drv1 for character devices. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0db65574bbb9: pbio: Store softc in si_drv1 for character devices..

jhb added a commit: rGf02bf967fcd3: pbio: Store softc in si_drv1 for character devices..May 20 2022, 12:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pbio/

pbio.c

74 lines

Diff 105467

View Options

pbio: Store softc in si_drv1 for character devices.ClosedPublicActions