arcmsr: Remove never-true NULL check from cdev callbacks.
ClosedPublic
Actions

Authored by jhb on Apr 20 2022, 8:15 PM.

Tags

None

Referenced Files

	F148170154: D35005.id.diff
	Mon, Mar 16, 6:14 AM

	F148130301: D35005.id.diff
	Mon, Mar 16, 12:12 AM

	F148117379: D35005.id.diff
	Sun, Mar 15, 10:02 PM

	Unknown Object (File)
	Sun, Mar 15, 1:43 AM

	Unknown Object (File)
	Sun, Mar 8, 11:43 PM

	Unknown Object (File)
	Sun, Mar 1, 12:38 PM

	Unknown Object (File)
	Jan 5 2026, 7:51 AM

	Unknown Object (File)
	Jan 1 2026, 1:21 AM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rGd2ebb215b8cf: arcmsr: Remove never-true NULL check from cdev callbacks.
rG108adb2ff52c: arcmsr: Remove never-true NULL check from cdev callbacks.

Summary

si_drv1 will always hold a non-NULL pointer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 20 2022, 8:15 PM

jhb created this revision.

jhb added a parent revision: D35004: arcmsr: Store softc pointer in si_drv1 of cdev..

Harbormaster completed remote builds in B45277: Diff 105235.Apr 20 2022, 8:15 PM

imp accepted this revision.Apr 20 2022, 9:23 PM

This revision is now accepted and ready to land.Apr 20 2022, 9:23 PM

Closed by commit rG108adb2ff52c: arcmsr: Remove never-true NULL check from cdev callbacks. (authored by jhb). · Explain WhyApr 21 2022, 5:31 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG108adb2ff52c: arcmsr: Remove never-true NULL check from cdev callbacks..

jhb added a commit: rGd2ebb215b8cf: arcmsr: Remove never-true NULL check from cdev callbacks..May 20 2022, 12:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

arcmsr/

arcmsr.c

13 lines

Diff 105290

View Options

arcmsr: Remove never-true NULL check from cdev callbacks.ClosedPublicActions