Page MenuHomeFreeBSD
Differential D35006

psm: Swap the unit member in the softc for a device_t.
ClosedPublic
Actions

Authored by jhb on Apr 20 2022, 8:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 9, 2:26 PM
Unknown Object (File)
Thu, Apr 9, 2:23 PM
Unknown Object (File)
Sun, Apr 5, 5:29 AM
Unknown Object (File)
Tue, Mar 24, 1:56 AM
Unknown Object (File)
Mon, Mar 23, 12:00 PM
Unknown Object (File)
Mar 18 2026, 4:32 AM
Unknown Object (File)
Mar 17 2026, 11:08 PM
Unknown Object (File)
Mar 17 2026, 6:55 AM
View All Files
Subscribers
None

Details

Reviewers
imp
Commits
rGdb3f075d8761: psm: Swap the unit member in the softc for a device_t.
rGa6c09f20e8e0: psm: Swap the unit member in the softc for a device_t.
Summary

This entails various changes to make this driver more "modern"
(new-bus vs pre-new-bus) using device_log() and device_printf() rather
than psm%d. It also fixes the device_busy/unbusy calls to use sc->dev
directly rather than looking the device_t up via the devclass and
unit.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45278
Build 42166: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 20 2022, 8:15 PM
jhb created this revision.
Harbormaster completed remote builds in B45278: Diff 105236.Apr 20 2022, 8:15 PM
imp accepted this revision.Apr 20 2022, 9:24 PM
imp added inline comments.
sys/dev/atkbdc/psm.c
1050

device_log() might not be a bad idea... But this is fine here.

This revision is now accepted and ready to land.Apr 20 2022, 9:24 PM
jhb added inline comments.Apr 21 2022, 4:14 PM
sys/dev/atkbdc/psm.c
1050

Oh, we have that now, yes. Ok, I'd rather use that.

jhb updated this revision to Diff 105269.Apr 21 2022, 4:34 PM
  • Use device_log.
This revision now requires review to proceed.Apr 21 2022, 4:34 PM
Harbormaster completed remote builds in B45300: Diff 105269.Apr 21 2022, 4:34 PM
jhb edited the summary of this revision. (Show Details)Apr 21 2022, 4:35 PM
imp accepted this revision.Apr 21 2022, 6:01 PM
This revision is now accepted and ready to land.Apr 21 2022, 6:01 PM
Closed by commit rGa6c09f20e8e0: psm: Swap the unit member in the softc for a device_t. (authored by jhb). · Explain WhyApr 21 2022, 8:55 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa6c09f20e8e0: psm: Swap the unit member in the softc for a device_t..
jhb added a commit: rGdb3f075d8761: psm: Swap the unit member in the softc for a device_t..Jan 24 2023, 4:48 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
atkbdc/
177 lines

Diff 105236

View Options

sys/dev/atkbdc/psm.c

Loading...