arcmsr: Remove never-true NULL check from cdev callbacks.
ClosedPublic
Actions

Authored by jhb on Apr 20 2022, 8:15 PM.

Tags

None

Referenced Files

	F166441904: D35005.id105290.diff
	Thu, Aug 13, 2:32 PM

	F166441847: D35005.diff
	Thu, Aug 13, 2:32 PM

	F166441795: D35005.id105235.diff
	Thu, Aug 13, 2:31 PM

	Unknown Object (File)
	Wed, Aug 12, 9:30 AM

	Unknown Object (File)
	Fri, Aug 7, 3:34 AM

	Unknown Object (File)
	Thu, Aug 6, 6:05 PM

	Unknown Object (File)
	Thu, Aug 6, 11:29 AM

	Unknown Object (File)
	Wed, Aug 5, 4:54 AM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rGd2ebb215b8cf: arcmsr: Remove never-true NULL check from cdev callbacks.
rG108adb2ff52c: arcmsr: Remove never-true NULL check from cdev callbacks.

Summary

si_drv1 will always hold a non-NULL pointer.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45277
Build 42165: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 20 2022, 8:15 PM

jhb created this revision.

jhb added a parent revision: D35004: arcmsr: Store softc pointer in si_drv1 of cdev..

Harbormaster completed remote builds in B45277: Diff 105235.Apr 20 2022, 8:15 PM

imp accepted this revision.Apr 20 2022, 9:23 PM

This revision is now accepted and ready to land.Apr 20 2022, 9:23 PM

Closed by commit rG108adb2ff52c: arcmsr: Remove never-true NULL check from cdev callbacks. (authored by jhb). · Explain WhyApr 21 2022, 5:31 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG108adb2ff52c: arcmsr: Remove never-true NULL check from cdev callbacks..

jhb added a commit: rGd2ebb215b8cf: arcmsr: Remove never-true NULL check from cdev callbacks..May 20 2022, 12:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

arcmsr/

arcmsr.c

13 lines

Diff 105235

View Options

arcmsr: Remove never-true NULL check from cdev callbacks.ClosedPublicActions