rtwn: Restore RF_ENV control type after initializing RF.
ClosedPublic
Actions

Authored by jhb on Apr 7 2022, 10:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 17, 4:03 PM

	Unknown Object (File)
	Mon, Aug 17, 4:03 PM

	Unknown Object (File)
	Mon, Aug 17, 4:02 PM

	Unknown Object (File)
	Sun, Aug 16, 7:09 PM

	Unknown Object (File)
	Sat, Aug 15, 9:18 PM

	Unknown Object (File)
	Fri, Aug 14, 9:28 PM

	Unknown Object (File)
	Thu, Aug 13, 8:53 PM

	Unknown Object (File)
	Tue, Aug 11, 11:47 PM

View All Files

Subscribers

None

Details

Reviewers

kevlo
imp

Commits

rG6aca4e6127e3: rtwn: Restore RF_ENV control type after initializing RF.
rG50e3b6aa480b: rtwn: Restore RF_ENV control type after initializing RF.

Summary

Both rwlwifi in Linux and rtwn in OpenBSD restore this register,
and the existing code was saving the value and not using it.

Reported by: -Wunused-but-set-variable
Obtained from: OpenBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 7 2022, 10:12 PM

jhb created this revision.

Harbormaster completed remote builds in B45070: Diff 104751.Apr 7 2022, 10:12 PM

imp accepted this revision.Apr 7 2022, 10:33 PM

This revision is now accepted and ready to land.Apr 7 2022, 10:33 PM

Closed by commit rG50e3b6aa480b: rtwn: Restore RF_ENV control type after initializing RF. (authored by jhb). · Explain WhyApr 8 2022, 12:05 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG50e3b6aa480b: rtwn: Restore RF_ENV control type after initializing RF..

jhb added a commit: rG6aca4e6127e3: rtwn: Restore RF_ENV control type after initializing RF..May 13 2022, 5:59 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

rtl8192e/

r92e_init.c

5 lines

Diff 104759

View Options

sys/dev/rtwn/rtl8192e/r92e_init.c

rtwn: Restore RF_ENV control type after initializing RF.ClosedPublicActions