Page MenuHomeFreeBSD
Differential D34597

test-includes: improve portability
ClosedPublic
Actions

Authored by brooks on Mar 17 2022, 11:47 PM.
Tags
None
Referenced Files
F111576636: D34597.id103971.diff
Wed, Mar 5, 12:14 PM
F111571350: D34597.id104097.diff
Wed, Mar 5, 10:22 AM
F111569518: D34597.diff
Wed, Mar 5, 9:46 AM
Unknown Object (File)
Sun, Mar 2, 6:47 AM
Unknown Object (File)
Fri, Feb 28, 4:16 AM
Unknown Object (File)
Thu, Feb 27, 10:17 PM
Unknown Object (File)
Thu, Feb 27, 5:20 PM
Unknown Object (File)
Jan 29 2025, 3:12 PM
View All 64 Files
Subscribers
None

Details

Reviewers
imp
Commits
rG44b36b80f578: test-includes: improve portability
Summary

FreeBSD's shell permits [^bar] to match characters not in [bar] like
common regular expressions. This is non-portable and '!' should be
used in place of '^' for portability.

Reported by: Nathaniel Wesley Filardo
Issue: https://github.com/CTSRD-CHERI/cheribsd/issues/1321

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Mar 17 2022, 11:47 PM
brooks created this revision.
Harbormaster completed remote builds in B44818: Diff 103971.Mar 17 2022, 11:47 PM
imp added inline comments.Mar 18 2022, 3:52 AM
tools/build/test-includes/Makefile
19

Looks good, or it could be [a-zA-z]*.h too...

imp accepted this revision.Mar 18 2022, 3:53 AM
This revision is now accepted and ready to land.Mar 18 2022, 3:53 AM
Closed by commit rG44b36b80f578: test-includes: improve portability (authored by brooks). · Explain WhyMar 22 2022, 8:24 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG44b36b80f578: test-includes: improve portability.

Revision Contents
Changeset List

PathSize
tools/
build/
test-includes/
2 lines

Diff 104097

View Options

tools/build/test-includes/Makefile

Loading...