Page MenuHomeFreeBSD
Differential D34597

test-includes: improve portability
ClosedPublic
Actions

Authored by brooks on Mar 17 2022, 11:47 PM.
Tags
None
Referenced Files
F152898703: D34597.id103971.diff
Fri, Apr 17, 9:34 PM
F152843835: D34597.id104097.diff
Fri, Apr 17, 11:23 AM
Unknown Object (File)
Tue, Apr 14, 6:09 AM
Unknown Object (File)
Sun, Apr 5, 5:52 PM
Unknown Object (File)
Mar 13 2026, 4:06 AM
Unknown Object (File)
Mar 1 2026, 4:19 PM
Unknown Object (File)
Feb 25 2026, 1:47 PM
Unknown Object (File)
Feb 8 2026, 8:43 AM
View All 99 Files
Subscribers
None

Details

Reviewers
imp
Commits
rG44b36b80f578: test-includes: improve portability
Summary

FreeBSD's shell permits [^bar] to match characters not in [bar] like
common regular expressions. This is non-portable and '!' should be
used in place of '^' for portability.

Reported by: Nathaniel Wesley Filardo
Issue: https://github.com/CTSRD-CHERI/cheribsd/issues/1321

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44818
Build 41706: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Mar 17 2022, 11:47 PM
brooks created this revision.
Harbormaster completed remote builds in B44818: Diff 103971.Mar 17 2022, 11:47 PM
imp added inline comments.Mar 18 2022, 3:52 AM
tools/build/test-includes/Makefile
19

Looks good, or it could be [a-zA-z]*.h too...

imp accepted this revision.Mar 18 2022, 3:53 AM
This revision is now accepted and ready to land.Mar 18 2022, 3:53 AM
Closed by commit rG44b36b80f578: test-includes: improve portability (authored by brooks). · Explain WhyMar 22 2022, 8:24 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG44b36b80f578: test-includes: improve portability.

Revision Contents
Changeset List

PathSize
tools/
build/
test-includes/
2 lines

Diff 103971

View Options

tools/build/test-includes/Makefile

Loading...