Page MenuHomeFreeBSD
Differential D34199

IPMI: Fixing whitespace
Needs ReviewPublic
Actions

Authored by david.elliott3040_gmail.com on Feb 8 2022, 12:25 PM.
Tags
None
Referenced Files
F152848567: D34199.id102487.diff
Fri, Apr 17, 12:10 PM
Unknown Object (File)
Tue, Apr 14, 8:32 PM
Unknown Object (File)
Sun, Apr 5, 5:25 PM
Unknown Object (File)
Fri, Mar 27, 1:37 AM
Unknown Object (File)
Thu, Mar 26, 8:03 PM
Unknown Object (File)
Mar 9 2026, 3:33 AM
Unknown Object (File)
Mar 9 2026, 3:32 AM
Unknown Object (File)
Feb 17 2026, 6:24 PM
View All 72 Files
Subscribers
imp

Details

Reviewers
mav
Summary

Erroneous whitespace in ipmivars.h

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

david.elliott3040_gmail.com created this revision.Feb 8 2022, 12:25 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 8 2022, 12:25 PM
david.elliott3040_gmail.com requested review of this revision.Feb 8 2022, 12:25 PM
david.elliott3040_gmail.com retitled this revision from Fixing whitespace to IPMI: Fixing whitespace.Feb 8 2022, 12:44 PM
david.elliott3040_gmail.com added a reviewer: mav.Feb 9 2022, 2:16 PM
mav added a comment.Feb 11 2022, 12:40 AM

I don't think it is erroneous. I think it was intentional to highlight different meaning of those constants. Such practice is often used when register addresses and values are listed together. Though yes, additional indentation is usually done not before #define, but after it.

Revision Contents
Changeset List

PathSize
sys/
dev/
ipmi/
10 lines

Diff 102487

View Options

sys/dev/ipmi/ipmivars.h

Loading...